Uh oh!
There was an error while loading. Please reload this page.
fix(publication): complete concurrent rotation handoff - #51
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hosted publication can retire a checkpoint's temporary hardlink between the path stat and the checkpoint open. The bytes and inode remain valid, but the bounded reader previously treated the
nlink 2 -> 1transition as an arbitrary mutation.A second rotation writer can also lose the claim-index
EEXISTrace while the winning writer has durably published the exact next epoch directory but has not published its checkpoint yet. That exactT,C1,E1,E2(empty),no C2root is a valid incomplete handoff, but claim publication revalidation lacked the authenticated rotation checkpoint needed to recognize it.Fix
EEXISTrevalidation.Verification
npm run checkBuilt with OpenAI Codex GPT-5.6 using Prime Agent.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.