fix(mobile): keep the iOS home header stable - #139

Merged
rynfar merged 1 commit into
pylonfrom
upstream/2026-08-28-ios-home-header
Aug 29, 2026
Merged

fix(mobile): keep the iOS home header stable#139
rynfar merged 1 commit into
pylonfrom
upstream/2026-08-28-ios-home-header

Conversation

@rynfar

@rynfarrynfar commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Rewrites the react-native-screens@4.25.2 patch so iOS header subviews are
collected into explicit left/right bar-button arrays instead of the navigation
item's items being cleared and rebuilt, which is what made the home header jump.

Adopted from T3 Code b982847ab201795711884d1dfadfddb3864adb23
(pingdotgg/t3code#8467), cherry-picked clean. Patch file plus lockfile only, no
Pylon source touched.

Scope note

This was originally scoped alongside upstream #8399 (Git action toast glass) as
one "mobile cosmetics" change. #8399 is not here because #138 already
contains it: #7327 rewrites GitActionProgressOverlay.tsx on top of #8399, and
that PR takes upstream's version of the file wholesale. Cherry-picking #8399
separately would have re-applied a superseded version.

Verification

  • pnpm install succeeds, so the rewritten patch applies against
    react-native-screens@4.25.2
  • Confirmed the patch actually landed rather than being silently skipped: the new
    subviewLeftItems symbol is present in the installed
    ios/RNSScreenStackHeaderConfig.mm
  • pnpm-lock.yaml is unchanged after install, so the committed lockfile matches
    what pnpm resolves
  • vp run -F @t3tools/mobile typecheck — clean; vp test run on mobile — 25 passed

Not verified

The patch is iOS native Objective-C. Nothing here proves the header actually
stops jumping — that needs a simulator or device run, which this change has not
had. Tests and typecheck can only show the patch is well-formed and the JS side
still resolves. Worth pairing with the test-pylon-mobile pass that #138 also
wants, since both land on the same surface.

Claude Opus 5 via Claude Code.


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@github-actionsgithub-actionsBot added size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Aug 28, 2026
@github-actions

github-actionsBot commented Aug 28, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB+47 B (+0.3%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB+46 B (+0.7%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB55.6 KiB+44 B (+0.1%)66.4 KiB
CodexLive turn messages910+1 (+11.1%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−3 B (−0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+16 B (+0.2%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.4 KiB−19 B (−0.3%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB−44 B (−0.1%)66.4 KiB
ClaudeLive turn messages1110−1 (−9.1%)21

Baseline: 3d6035f · PR result: bb99f51 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar

Copy link
Copy Markdown
CollaboratorAuthor

Independent review pass. Two findings, both latent, neither fixed.

The review verified more than my own pass could: it reverse-applied the previous
patch against pristine react-native-screens@4.25.2, applied the new one, and
read the resulting ios/RNSScreenStackHeaderConfig.mm in final form. It cleared
the things worth worrying about in a native patch — no retain cycle from
retaining config on the navigation item (screenView is weak and
RNSScreen.shouldBeRecycled is NO), the @[...] literal cannot take a nil
element, dropping the leftBarButtonItems = nil resets is safe because iOS 16+
never writes that property now, and the nil→empty-array change only affects the
pre-iOS-16 branch, which is dead at the app's 18.0 deployment target.

Stale grouping when hidesSharedBackground toggles. The reuse cache is keyed
on [subview getUIBarButtonItem] object identity, but -setHidesSharedBackground:
mutates that cached item in place, so toggling the prop on a React header subview
no longer recomputes leading/trailingItemGroups. Previously any subview item
forced a rebuild every pass. Mechanism confirmed; not reachable today, because
Pylon only sets that prop on dict-based items, which are in the key.

Reuse key omits navitem.searchController. The searchBarPlacement branch
builds items from it, so a first pass taken before the search bar subview mounts
could be cached permanently. Newly reachable for screens with React header
subviews, but not exercised by current Pylon mobile code.

Both are latent upstream issues in vendored native code and neither is verifiable
without a device, so I have not touched them. They are worth re-checking during
the test-pylon-mobile pass this PR already needs, particularly if a header
search bar or a hidesSharedBackground toggle lands later.

Co-authored-by: Julius Marminge <julius@mac.lan>
(cherry picked from commit b982847ab201795711884d1dfadfddb3864adb23)
@rynfar
rynfarforce-pushed the upstream/2026-08-28-ios-home-header branch from 62fdc19 to bb99f51CompareAugust 29, 2026 02:55
@rynfar
rynfar merged commit 88d2328 into pylonAug 29, 2026
15 checks passed
@rynfar
rynfar deleted the upstream/2026-08-28-ios-home-header branch August 29, 2026 03:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Lvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rynfar@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(mobile): keep the iOS home header stable - #139

Merged
rynfar merged 1 commit into
pylonfrom
upstream/2026-08-28-ios-home-header
Aug 29, 2026
Merged

fix(mobile): keep the iOS home header stable#139
rynfar merged 1 commit into
pylonfrom
upstream/2026-08-28-ios-home-header

Conversation

@rynfar

@rynfarrynfar commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Rewrites the react-native-screens@4.25.2 patch so iOS header subviews are
collected into explicit left/right bar-button arrays instead of the navigation
item's items being cleared and rebuilt, which is what made the home header jump.

Adopted from T3 Code b982847ab201795711884d1dfadfddb3864adb23
(pingdotgg/t3code#8467), cherry-picked clean. Patch file plus lockfile only, no
Pylon source touched.

Scope note

This was originally scoped alongside upstream #8399 (Git action toast glass) as
one "mobile cosmetics" change. #8399 is not here because #138 already
contains it: #7327 rewrites GitActionProgressOverlay.tsx on top of #8399, and
that PR takes upstream's version of the file wholesale. Cherry-picking #8399
separately would have re-applied a superseded version.

Verification

  • pnpm install succeeds, so the rewritten patch applies against
    react-native-screens@4.25.2
  • Confirmed the patch actually landed rather than being silently skipped: the new
    subviewLeftItems symbol is present in the installed
    ios/RNSScreenStackHeaderConfig.mm
  • pnpm-lock.yaml is unchanged after install, so the committed lockfile matches
    what pnpm resolves
  • vp run -F @t3tools/mobile typecheck — clean; vp test run on mobile — 25 passed

Not verified

The patch is iOS native Objective-C. Nothing here proves the header actually
stops jumping — that needs a simulator or device run, which this change has not
had. Tests and typecheck can only show the patch is well-formed and the JS side
still resolves. Worth pairing with the test-pylon-mobile pass that #138 also
wants, since both land on the same surface.

Claude Opus 5 via Claude Code.


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@github-actionsgithub-actionsBot added size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Aug 28, 2026
@github-actions

github-actionsBot commented Aug 28, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB+47 B (+0.3%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB+46 B (+0.7%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB55.6 KiB+44 B (+0.1%)66.4 KiB
CodexLive turn messages910+1 (+11.1%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−3 B (−0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+16 B (+0.2%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.4 KiB−19 B (−0.3%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB−44 B (−0.1%)66.4 KiB
ClaudeLive turn messages1110−1 (−9.1%)21

Baseline: 3d6035f · PR result: bb99f51 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar

Copy link
Copy Markdown
CollaboratorAuthor

Independent review pass. Two findings, both latent, neither fixed.

The review verified more than my own pass could: it reverse-applied the previous
patch against pristine react-native-screens@4.25.2, applied the new one, and
read the resulting ios/RNSScreenStackHeaderConfig.mm in final form. It cleared
the things worth worrying about in a native patch — no retain cycle from
retaining config on the navigation item (screenView is weak and
RNSScreen.shouldBeRecycled is NO), the @[...] literal cannot take a nil
element, dropping the leftBarButtonItems = nil resets is safe because iOS 16+
never writes that property now, and the nil→empty-array change only affects the
pre-iOS-16 branch, which is dead at the app's 18.0 deployment target.

Stale grouping when hidesSharedBackground toggles. The reuse cache is keyed
on [subview getUIBarButtonItem] object identity, but -setHidesSharedBackground:
mutates that cached item in place, so toggling the prop on a React header subview
no longer recomputes leading/trailingItemGroups. Previously any subview item
forced a rebuild every pass. Mechanism confirmed; not reachable today, because
Pylon only sets that prop on dict-based items, which are in the key.

Reuse key omits navitem.searchController. The searchBarPlacement branch
builds items from it, so a first pass taken before the search bar subview mounts
could be cached permanently. Newly reachable for screens with React header
subviews, but not exercised by current Pylon mobile code.

Both are latent upstream issues in vendored native code and neither is verifiable
without a device, so I have not touched them. They are worth re-checking during
the test-pylon-mobile pass this PR already needs, particularly if a header
search bar or a hidesSharedBackground toggle lands later.

Co-authored-by: Julius Marminge <julius@mac.lan>
(cherry picked from commit b982847ab201795711884d1dfadfddb3864adb23)
@rynfar
rynfarforce-pushed the upstream/2026-08-28-ios-home-header branch from 62fdc19 to bb99f51CompareAugust 29, 2026 02:55
@rynfar
rynfar merged commit 88d2328 into pylonAug 29, 2026
15 checks passed
@rynfar
rynfar deleted the upstream/2026-08-28-ios-home-header branch August 29, 2026 03:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Lvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rynfar@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(mobile): keep the iOS home header stable - #139

Merged
rynfar merged 1 commit into
pylonfrom
upstream/2026-08-28-ios-home-header
Aug 29, 2026
Merged

fix(mobile): keep the iOS home header stable#139
rynfar merged 1 commit into
pylonfrom
upstream/2026-08-28-ios-home-header

Conversation

@rynfar

@rynfarrynfar commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Rewrites the react-native-screens@4.25.2 patch so iOS header subviews are
collected into explicit left/right bar-button arrays instead of the navigation
item's items being cleared and rebuilt, which is what made the home header jump.

Adopted from T3 Code b982847ab201795711884d1dfadfddb3864adb23
(pingdotgg/t3code#8467), cherry-picked clean. Patch file plus lockfile only, no
Pylon source touched.

Scope note

This was originally scoped alongside upstream #8399 (Git action toast glass) as
one "mobile cosmetics" change. #8399 is not here because #138 already
contains it: #7327 rewrites GitActionProgressOverlay.tsx on top of #8399, and
that PR takes upstream's version of the file wholesale. Cherry-picking #8399
separately would have re-applied a superseded version.

Verification

  • pnpm install succeeds, so the rewritten patch applies against
    react-native-screens@4.25.2
  • Confirmed the patch actually landed rather than being silently skipped: the new
    subviewLeftItems symbol is present in the installed
    ios/RNSScreenStackHeaderConfig.mm
  • pnpm-lock.yaml is unchanged after install, so the committed lockfile matches
    what pnpm resolves
  • vp run -F @t3tools/mobile typecheck — clean; vp test run on mobile — 25 passed

Not verified

The patch is iOS native Objective-C. Nothing here proves the header actually
stops jumping — that needs a simulator or device run, which this change has not
had. Tests and typecheck can only show the patch is well-formed and the JS side
still resolves. Worth pairing with the test-pylon-mobile pass that #138 also
wants, since both land on the same surface.

Claude Opus 5 via Claude Code.


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@github-actionsgithub-actionsBot added size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Aug 28, 2026
@github-actions

github-actionsBot commented Aug 28, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB+47 B (+0.3%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB+46 B (+0.7%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB55.6 KiB+44 B (+0.1%)66.4 KiB
CodexLive turn messages910+1 (+11.1%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−3 B (−0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+16 B (+0.2%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.4 KiB−19 B (−0.3%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB−44 B (−0.1%)66.4 KiB
ClaudeLive turn messages1110−1 (−9.1%)21

Baseline: 3d6035f · PR result: bb99f51 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar

Copy link
Copy Markdown
CollaboratorAuthor

Independent review pass. Two findings, both latent, neither fixed.

The review verified more than my own pass could: it reverse-applied the previous
patch against pristine react-native-screens@4.25.2, applied the new one, and
read the resulting ios/RNSScreenStackHeaderConfig.mm in final form. It cleared
the things worth worrying about in a native patch — no retain cycle from
retaining config on the navigation item (screenView is weak and
RNSScreen.shouldBeRecycled is NO), the @[...] literal cannot take a nil
element, dropping the leftBarButtonItems = nil resets is safe because iOS 16+
never writes that property now, and the nil→empty-array change only affects the
pre-iOS-16 branch, which is dead at the app's 18.0 deployment target.

Stale grouping when hidesSharedBackground toggles. The reuse cache is keyed
on [subview getUIBarButtonItem] object identity, but -setHidesSharedBackground:
mutates that cached item in place, so toggling the prop on a React header subview
no longer recomputes leading/trailingItemGroups. Previously any subview item
forced a rebuild every pass. Mechanism confirmed; not reachable today, because
Pylon only sets that prop on dict-based items, which are in the key.

Reuse key omits navitem.searchController. The searchBarPlacement branch
builds items from it, so a first pass taken before the search bar subview mounts
could be cached permanently. Newly reachable for screens with React header
subviews, but not exercised by current Pylon mobile code.

Both are latent upstream issues in vendored native code and neither is verifiable
without a device, so I have not touched them. They are worth re-checking during
the test-pylon-mobile pass this PR already needs, particularly if a header
search bar or a hidesSharedBackground toggle lands later.

Co-authored-by: Julius Marminge <julius@mac.lan>
(cherry picked from commit b982847ab201795711884d1dfadfddb3864adb23)
@rynfar
rynfarforce-pushed the upstream/2026-08-28-ios-home-header branch from 62fdc19 to bb99f51CompareAugust 29, 2026 02:55
@rynfar
rynfar merged commit 88d2328 into pylonAug 29, 2026
15 checks passed
@rynfar
rynfar deleted the upstream/2026-08-28-ios-home-header branch August 29, 2026 03:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Lvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rynfar@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(mobile): keep the iOS home header stable - #139

Merged
rynfar merged 1 commit into
pylonfrom
upstream/2026-08-28-ios-home-header
Aug 29, 2026
Merged

fix(mobile): keep the iOS home header stable#139
rynfar merged 1 commit into
pylonfrom
upstream/2026-08-28-ios-home-header

Conversation

@rynfar

@rynfarrynfar commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Rewrites the react-native-screens@4.25.2 patch so iOS header subviews are
collected into explicit left/right bar-button arrays instead of the navigation
item's items being cleared and rebuilt, which is what made the home header jump.

Adopted from T3 Code b982847ab201795711884d1dfadfddb3864adb23
(pingdotgg/t3code#8467), cherry-picked clean. Patch file plus lockfile only, no
Pylon source touched.

Scope note

This was originally scoped alongside upstream #8399 (Git action toast glass) as
one "mobile cosmetics" change. #8399 is not here because #138 already
contains it: #7327 rewrites GitActionProgressOverlay.tsx on top of #8399, and
that PR takes upstream's version of the file wholesale. Cherry-picking #8399
separately would have re-applied a superseded version.

Verification

  • pnpm install succeeds, so the rewritten patch applies against
    react-native-screens@4.25.2
  • Confirmed the patch actually landed rather than being silently skipped: the new
    subviewLeftItems symbol is present in the installed
    ios/RNSScreenStackHeaderConfig.mm
  • pnpm-lock.yaml is unchanged after install, so the committed lockfile matches
    what pnpm resolves
  • vp run -F @t3tools/mobile typecheck — clean; vp test run on mobile — 25 passed

Not verified

The patch is iOS native Objective-C. Nothing here proves the header actually
stops jumping — that needs a simulator or device run, which this change has not
had. Tests and typecheck can only show the patch is well-formed and the JS side
still resolves. Worth pairing with the test-pylon-mobile pass that #138 also
wants, since both land on the same surface.

Claude Opus 5 via Claude Code.


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@github-actionsgithub-actionsBot added size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Aug 28, 2026
@github-actions

github-actionsBot commented Aug 28, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB+47 B (+0.3%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB+46 B (+0.7%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB55.6 KiB+44 B (+0.1%)66.4 KiB
CodexLive turn messages910+1 (+11.1%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−3 B (−0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+16 B (+0.2%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.4 KiB−19 B (−0.3%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB−44 B (−0.1%)66.4 KiB
ClaudeLive turn messages1110−1 (−9.1%)21

Baseline: 3d6035f · PR result: bb99f51 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar

Copy link
Copy Markdown
CollaboratorAuthor

Independent review pass. Two findings, both latent, neither fixed.

The review verified more than my own pass could: it reverse-applied the previous
patch against pristine react-native-screens@4.25.2, applied the new one, and
read the resulting ios/RNSScreenStackHeaderConfig.mm in final form. It cleared
the things worth worrying about in a native patch — no retain cycle from
retaining config on the navigation item (screenView is weak and
RNSScreen.shouldBeRecycled is NO), the @[...] literal cannot take a nil
element, dropping the leftBarButtonItems = nil resets is safe because iOS 16+
never writes that property now, and the nil→empty-array change only affects the
pre-iOS-16 branch, which is dead at the app's 18.0 deployment target.

Stale grouping when hidesSharedBackground toggles. The reuse cache is keyed
on [subview getUIBarButtonItem] object identity, but -setHidesSharedBackground:
mutates that cached item in place, so toggling the prop on a React header subview
no longer recomputes leading/trailingItemGroups. Previously any subview item
forced a rebuild every pass. Mechanism confirmed; not reachable today, because
Pylon only sets that prop on dict-based items, which are in the key.

Reuse key omits navitem.searchController. The searchBarPlacement branch
builds items from it, so a first pass taken before the search bar subview mounts
could be cached permanently. Newly reachable for screens with React header
subviews, but not exercised by current Pylon mobile code.

Both are latent upstream issues in vendored native code and neither is verifiable
without a device, so I have not touched them. They are worth re-checking during
the test-pylon-mobile pass this PR already needs, particularly if a header
search bar or a hidesSharedBackground toggle lands later.

Co-authored-by: Julius Marminge <julius@mac.lan>
(cherry picked from commit b982847ab201795711884d1dfadfddb3864adb23)
@rynfar
rynfarforce-pushed the upstream/2026-08-28-ios-home-header branch from 62fdc19 to bb99f51CompareAugust 29, 2026 02:55
@rynfar
rynfar merged commit 88d2328 into pylonAug 29, 2026
15 checks passed
@rynfar
rynfar deleted the upstream/2026-08-28-ios-home-header branch August 29, 2026 03:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Lvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rynfar@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(mobile): keep the iOS home header stable - #139

Merged
rynfar merged 1 commit into
pylonfrom
upstream/2026-08-28-ios-home-header
Aug 29, 2026
Merged

fix(mobile): keep the iOS home header stable#139
rynfar merged 1 commit into
pylonfrom
upstream/2026-08-28-ios-home-header

Conversation

@rynfar

@rynfarrynfar commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Rewrites the react-native-screens@4.25.2 patch so iOS header subviews are
collected into explicit left/right bar-button arrays instead of the navigation
item's items being cleared and rebuilt, which is what made the home header jump.

Adopted from T3 Code b982847ab201795711884d1dfadfddb3864adb23
(pingdotgg/t3code#8467), cherry-picked clean. Patch file plus lockfile only, no
Pylon source touched.

Scope note

This was originally scoped alongside upstream #8399 (Git action toast glass) as
one "mobile cosmetics" change. #8399 is not here because #138 already
contains it: #7327 rewrites GitActionProgressOverlay.tsx on top of #8399, and
that PR takes upstream's version of the file wholesale. Cherry-picking #8399
separately would have re-applied a superseded version.

Verification

  • pnpm install succeeds, so the rewritten patch applies against
    react-native-screens@4.25.2
  • Confirmed the patch actually landed rather than being silently skipped: the new
    subviewLeftItems symbol is present in the installed
    ios/RNSScreenStackHeaderConfig.mm
  • pnpm-lock.yaml is unchanged after install, so the committed lockfile matches
    what pnpm resolves
  • vp run -F @t3tools/mobile typecheck — clean; vp test run on mobile — 25 passed

Not verified

The patch is iOS native Objective-C. Nothing here proves the header actually
stops jumping — that needs a simulator or device run, which this change has not
had. Tests and typecheck can only show the patch is well-formed and the JS side
still resolves. Worth pairing with the test-pylon-mobile pass that #138 also
wants, since both land on the same surface.

Claude Opus 5 via Claude Code.


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@github-actionsgithub-actionsBot added size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Aug 28, 2026
@github-actions

github-actionsBot commented Aug 28, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB+47 B (+0.3%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB+46 B (+0.7%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB55.6 KiB+44 B (+0.1%)66.4 KiB
CodexLive turn messages910+1 (+11.1%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−3 B (−0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+16 B (+0.2%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.4 KiB−19 B (−0.3%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB−44 B (−0.1%)66.4 KiB
ClaudeLive turn messages1110−1 (−9.1%)21

Baseline: 3d6035f · PR result: bb99f51 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar

Copy link
Copy Markdown
CollaboratorAuthor

Independent review pass. Two findings, both latent, neither fixed.

The review verified more than my own pass could: it reverse-applied the previous
patch against pristine react-native-screens@4.25.2, applied the new one, and
read the resulting ios/RNSScreenStackHeaderConfig.mm in final form. It cleared
the things worth worrying about in a native patch — no retain cycle from
retaining config on the navigation item (screenView is weak and
RNSScreen.shouldBeRecycled is NO), the @[...] literal cannot take a nil
element, dropping the leftBarButtonItems = nil resets is safe because iOS 16+
never writes that property now, and the nil→empty-array change only affects the
pre-iOS-16 branch, which is dead at the app's 18.0 deployment target.

Stale grouping when hidesSharedBackground toggles. The reuse cache is keyed
on [subview getUIBarButtonItem] object identity, but -setHidesSharedBackground:
mutates that cached item in place, so toggling the prop on a React header subview
no longer recomputes leading/trailingItemGroups. Previously any subview item
forced a rebuild every pass. Mechanism confirmed; not reachable today, because
Pylon only sets that prop on dict-based items, which are in the key.

Reuse key omits navitem.searchController. The searchBarPlacement branch
builds items from it, so a first pass taken before the search bar subview mounts
could be cached permanently. Newly reachable for screens with React header
subviews, but not exercised by current Pylon mobile code.

Both are latent upstream issues in vendored native code and neither is verifiable
without a device, so I have not touched them. They are worth re-checking during
the test-pylon-mobile pass this PR already needs, particularly if a header
search bar or a hidesSharedBackground toggle lands later.

Co-authored-by: Julius Marminge <julius@mac.lan>
(cherry picked from commit b982847ab201795711884d1dfadfddb3864adb23)
@rynfar
rynfarforce-pushed the upstream/2026-08-28-ios-home-header branch from 62fdc19 to bb99f51CompareAugust 29, 2026 02:55
@rynfar
rynfar merged commit 88d2328 into pylonAug 29, 2026
15 checks passed
@rynfar
rynfar deleted the upstream/2026-08-28-ios-home-header branch August 29, 2026 03:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Lvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rynfar@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(mobile): keep the iOS home header stable - #139

Merged
rynfar merged 1 commit into
pylonfrom
upstream/2026-08-28-ios-home-header
Aug 29, 2026
Merged

fix(mobile): keep the iOS home header stable#139
rynfar merged 1 commit into
pylonfrom
upstream/2026-08-28-ios-home-header

Conversation

@rynfar

@rynfarrynfar commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Rewrites the react-native-screens@4.25.2 patch so iOS header subviews are
collected into explicit left/right bar-button arrays instead of the navigation
item's items being cleared and rebuilt, which is what made the home header jump.

Adopted from T3 Code b982847ab201795711884d1dfadfddb3864adb23
(pingdotgg/t3code#8467), cherry-picked clean. Patch file plus lockfile only, no
Pylon source touched.

Scope note

This was originally scoped alongside upstream #8399 (Git action toast glass) as
one "mobile cosmetics" change. #8399 is not here because #138 already
contains it: #7327 rewrites GitActionProgressOverlay.tsx on top of #8399, and
that PR takes upstream's version of the file wholesale. Cherry-picking #8399
separately would have re-applied a superseded version.

Verification

  • pnpm install succeeds, so the rewritten patch applies against
    react-native-screens@4.25.2
  • Confirmed the patch actually landed rather than being silently skipped: the new
    subviewLeftItems symbol is present in the installed
    ios/RNSScreenStackHeaderConfig.mm
  • pnpm-lock.yaml is unchanged after install, so the committed lockfile matches
    what pnpm resolves
  • vp run -F @t3tools/mobile typecheck — clean; vp test run on mobile — 25 passed

Not verified

The patch is iOS native Objective-C. Nothing here proves the header actually
stops jumping — that needs a simulator or device run, which this change has not
had. Tests and typecheck can only show the patch is well-formed and the JS side
still resolves. Worth pairing with the test-pylon-mobile pass that #138 also
wants, since both land on the same surface.

Claude Opus 5 via Claude Code.


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@github-actionsgithub-actionsBot added size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Aug 28, 2026
@github-actions

github-actionsBot commented Aug 28, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB+47 B (+0.3%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB+46 B (+0.7%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB55.6 KiB+44 B (+0.1%)66.4 KiB
CodexLive turn messages910+1 (+11.1%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−3 B (−0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+16 B (+0.2%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.4 KiB−19 B (−0.3%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB−44 B (−0.1%)66.4 KiB
ClaudeLive turn messages1110−1 (−9.1%)21

Baseline: 3d6035f · PR result: bb99f51 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar

Copy link
Copy Markdown
CollaboratorAuthor

Independent review pass. Two findings, both latent, neither fixed.

The review verified more than my own pass could: it reverse-applied the previous
patch against pristine react-native-screens@4.25.2, applied the new one, and
read the resulting ios/RNSScreenStackHeaderConfig.mm in final form. It cleared
the things worth worrying about in a native patch — no retain cycle from
retaining config on the navigation item (screenView is weak and
RNSScreen.shouldBeRecycled is NO), the @[...] literal cannot take a nil
element, dropping the leftBarButtonItems = nil resets is safe because iOS 16+
never writes that property now, and the nil→empty-array change only affects the
pre-iOS-16 branch, which is dead at the app's 18.0 deployment target.

Stale grouping when hidesSharedBackground toggles. The reuse cache is keyed
on [subview getUIBarButtonItem] object identity, but -setHidesSharedBackground:
mutates that cached item in place, so toggling the prop on a React header subview
no longer recomputes leading/trailingItemGroups. Previously any subview item
forced a rebuild every pass. Mechanism confirmed; not reachable today, because
Pylon only sets that prop on dict-based items, which are in the key.

Reuse key omits navitem.searchController. The searchBarPlacement branch
builds items from it, so a first pass taken before the search bar subview mounts
could be cached permanently. Newly reachable for screens with React header
subviews, but not exercised by current Pylon mobile code.

Both are latent upstream issues in vendored native code and neither is verifiable
without a device, so I have not touched them. They are worth re-checking during
the test-pylon-mobile pass this PR already needs, particularly if a header
search bar or a hidesSharedBackground toggle lands later.

Co-authored-by: Julius Marminge <julius@mac.lan>
(cherry picked from commit b982847ab201795711884d1dfadfddb3864adb23)
@rynfar
rynfarforce-pushed the upstream/2026-08-28-ios-home-header branch from 62fdc19 to bb99f51CompareAugust 29, 2026 02:55
@rynfar
rynfar merged commit 88d2328 into pylonAug 29, 2026
15 checks passed
@rynfar
rynfar deleted the upstream/2026-08-28-ios-home-header branch August 29, 2026 03:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Lvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rynfar@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(mobile): keep the iOS home header stable - #139

Merged
rynfar merged 1 commit into
pylonfrom
upstream/2026-08-28-ios-home-header
Aug 29, 2026
Merged

fix(mobile): keep the iOS home header stable#139
rynfar merged 1 commit into
pylonfrom
upstream/2026-08-28-ios-home-header

Conversation

@rynfar

@rynfarrynfar commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Rewrites the react-native-screens@4.25.2 patch so iOS header subviews are
collected into explicit left/right bar-button arrays instead of the navigation
item's items being cleared and rebuilt, which is what made the home header jump.

Adopted from T3 Code b982847ab201795711884d1dfadfddb3864adb23
(pingdotgg/t3code#8467), cherry-picked clean. Patch file plus lockfile only, no
Pylon source touched.

Scope note

This was originally scoped alongside upstream #8399 (Git action toast glass) as
one "mobile cosmetics" change. #8399 is not here because #138 already
contains it: #7327 rewrites GitActionProgressOverlay.tsx on top of #8399, and
that PR takes upstream's version of the file wholesale. Cherry-picking #8399
separately would have re-applied a superseded version.

Verification

  • pnpm install succeeds, so the rewritten patch applies against
    react-native-screens@4.25.2
  • Confirmed the patch actually landed rather than being silently skipped: the new
    subviewLeftItems symbol is present in the installed
    ios/RNSScreenStackHeaderConfig.mm
  • pnpm-lock.yaml is unchanged after install, so the committed lockfile matches
    what pnpm resolves
  • vp run -F @t3tools/mobile typecheck — clean; vp test run on mobile — 25 passed

Not verified

The patch is iOS native Objective-C. Nothing here proves the header actually
stops jumping — that needs a simulator or device run, which this change has not
had. Tests and typecheck can only show the patch is well-formed and the JS side
still resolves. Worth pairing with the test-pylon-mobile pass that #138 also
wants, since both land on the same surface.

Claude Opus 5 via Claude Code.


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@github-actionsgithub-actionsBot added size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Aug 28, 2026
@github-actions

github-actionsBot commented Aug 28, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB+47 B (+0.3%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB+46 B (+0.7%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB55.6 KiB+44 B (+0.1%)66.4 KiB
CodexLive turn messages910+1 (+11.1%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−3 B (−0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+16 B (+0.2%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.4 KiB−19 B (−0.3%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB−44 B (−0.1%)66.4 KiB
ClaudeLive turn messages1110−1 (−9.1%)21

Baseline: 3d6035f · PR result: bb99f51 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar

Copy link
Copy Markdown
CollaboratorAuthor

Independent review pass. Two findings, both latent, neither fixed.

The review verified more than my own pass could: it reverse-applied the previous
patch against pristine react-native-screens@4.25.2, applied the new one, and
read the resulting ios/RNSScreenStackHeaderConfig.mm in final form. It cleared
the things worth worrying about in a native patch — no retain cycle from
retaining config on the navigation item (screenView is weak and
RNSScreen.shouldBeRecycled is NO), the @[...] literal cannot take a nil
element, dropping the leftBarButtonItems = nil resets is safe because iOS 16+
never writes that property now, and the nil→empty-array change only affects the
pre-iOS-16 branch, which is dead at the app's 18.0 deployment target.

Stale grouping when hidesSharedBackground toggles. The reuse cache is keyed
on [subview getUIBarButtonItem] object identity, but -setHidesSharedBackground:
mutates that cached item in place, so toggling the prop on a React header subview
no longer recomputes leading/trailingItemGroups. Previously any subview item
forced a rebuild every pass. Mechanism confirmed; not reachable today, because
Pylon only sets that prop on dict-based items, which are in the key.

Reuse key omits navitem.searchController. The searchBarPlacement branch
builds items from it, so a first pass taken before the search bar subview mounts
could be cached permanently. Newly reachable for screens with React header
subviews, but not exercised by current Pylon mobile code.

Both are latent upstream issues in vendored native code and neither is verifiable
without a device, so I have not touched them. They are worth re-checking during
the test-pylon-mobile pass this PR already needs, particularly if a header
search bar or a hidesSharedBackground toggle lands later.

Co-authored-by: Julius Marminge <julius@mac.lan>
(cherry picked from commit b982847ab201795711884d1dfadfddb3864adb23)
@rynfar
rynfarforce-pushed the upstream/2026-08-28-ios-home-header branch from 62fdc19 to bb99f51CompareAugust 29, 2026 02:55
@rynfar
rynfar merged commit 88d2328 into pylonAug 29, 2026
15 checks passed
@rynfar
rynfar deleted the upstream/2026-08-28-ios-home-header branch August 29, 2026 03:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Lvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rynfar@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(mobile): keep the iOS home header stable - #139

Merged
rynfar merged 1 commit into
pylonfrom
upstream/2026-08-28-ios-home-header
Aug 29, 2026
Merged

fix(mobile): keep the iOS home header stable#139
rynfar merged 1 commit into
pylonfrom
upstream/2026-08-28-ios-home-header

Conversation

@rynfar

@rynfarrynfar commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Rewrites the react-native-screens@4.25.2 patch so iOS header subviews are
collected into explicit left/right bar-button arrays instead of the navigation
item's items being cleared and rebuilt, which is what made the home header jump.

Adopted from T3 Code b982847ab201795711884d1dfadfddb3864adb23
(pingdotgg/t3code#8467), cherry-picked clean. Patch file plus lockfile only, no
Pylon source touched.

Scope note

This was originally scoped alongside upstream #8399 (Git action toast glass) as
one "mobile cosmetics" change. #8399 is not here because #138 already
contains it: #7327 rewrites GitActionProgressOverlay.tsx on top of #8399, and
that PR takes upstream's version of the file wholesale. Cherry-picking #8399
separately would have re-applied a superseded version.

Verification

  • pnpm install succeeds, so the rewritten patch applies against
    react-native-screens@4.25.2
  • Confirmed the patch actually landed rather than being silently skipped: the new
    subviewLeftItems symbol is present in the installed
    ios/RNSScreenStackHeaderConfig.mm
  • pnpm-lock.yaml is unchanged after install, so the committed lockfile matches
    what pnpm resolves
  • vp run -F @t3tools/mobile typecheck — clean; vp test run on mobile — 25 passed

Not verified

The patch is iOS native Objective-C. Nothing here proves the header actually
stops jumping — that needs a simulator or device run, which this change has not
had. Tests and typecheck can only show the patch is well-formed and the JS side
still resolves. Worth pairing with the test-pylon-mobile pass that #138 also
wants, since both land on the same surface.

Claude Opus 5 via Claude Code.


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@github-actionsgithub-actionsBot added size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Aug 28, 2026
@github-actions

github-actionsBot commented Aug 28, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB+47 B (+0.3%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB+46 B (+0.7%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB55.6 KiB+44 B (+0.1%)66.4 KiB
CodexLive turn messages910+1 (+11.1%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−3 B (−0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+16 B (+0.2%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.4 KiB−19 B (−0.3%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB−44 B (−0.1%)66.4 KiB
ClaudeLive turn messages1110−1 (−9.1%)21

Baseline: 3d6035f · PR result: bb99f51 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar

Copy link
Copy Markdown
CollaboratorAuthor

Independent review pass. Two findings, both latent, neither fixed.

The review verified more than my own pass could: it reverse-applied the previous
patch against pristine react-native-screens@4.25.2, applied the new one, and
read the resulting ios/RNSScreenStackHeaderConfig.mm in final form. It cleared
the things worth worrying about in a native patch — no retain cycle from
retaining config on the navigation item (screenView is weak and
RNSScreen.shouldBeRecycled is NO), the @[...] literal cannot take a nil
element, dropping the leftBarButtonItems = nil resets is safe because iOS 16+
never writes that property now, and the nil→empty-array change only affects the
pre-iOS-16 branch, which is dead at the app's 18.0 deployment target.

Stale grouping when hidesSharedBackground toggles. The reuse cache is keyed
on [subview getUIBarButtonItem] object identity, but -setHidesSharedBackground:
mutates that cached item in place, so toggling the prop on a React header subview
no longer recomputes leading/trailingItemGroups. Previously any subview item
forced a rebuild every pass. Mechanism confirmed; not reachable today, because
Pylon only sets that prop on dict-based items, which are in the key.

Reuse key omits navitem.searchController. The searchBarPlacement branch
builds items from it, so a first pass taken before the search bar subview mounts
could be cached permanently. Newly reachable for screens with React header
subviews, but not exercised by current Pylon mobile code.

Both are latent upstream issues in vendored native code and neither is verifiable
without a device, so I have not touched them. They are worth re-checking during
the test-pylon-mobile pass this PR already needs, particularly if a header
search bar or a hidesSharedBackground toggle lands later.

Co-authored-by: Julius Marminge <julius@mac.lan>
(cherry picked from commit b982847ab201795711884d1dfadfddb3864adb23)
@rynfar
rynfarforce-pushed the upstream/2026-08-28-ios-home-header branch from 62fdc19 to bb99f51CompareAugust 29, 2026 02:55
@rynfar
rynfar merged commit 88d2328 into pylonAug 29, 2026
15 checks passed
@rynfar
rynfar deleted the upstream/2026-08-28-ios-home-header branch August 29, 2026 03:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Lvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rynfar@juliusmarminge