fix(ci): repair the Windows probe test and actually run repository suites - #161

Merged
rynfar merged 1 commit into
pylonfrom
fix/windows-native-probe-test
Aug 29, 2026
Merged

fix(ci): repair the Windows probe test and actually run repository suites#161
rynfar merged 1 commit into
pylonfrom
fix/windows-native-probe-test

Conversation

@rynfar

@rynfarrynfar commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

scripts/build-desktop-artifact.test.ts has been failing on pylon:

× skips the primary native probe for cross-architecture Windows payloads
AssertionError: expected true to be false

The test was wrong, not the code

It asserted that no spawned command carried ELECTRON_RUN_AS_NODE=1. But
verifyWindowsPrimaryFffNativeLoad spreads process.env into the child, so that
assertion trips whenever the runner itself has the variable set — which is the
case under any Electron-hosted shell. The arch gate was skipping the probe
correctly the whole time; the test was reading an inherited environment variable
and calling it evidence.

It now asserts what it means: the packaged executable was never spawned.
That is the only thing the probe does, and it cannot be faked by inheritance.

Why nobody noticed

CI never ran the file. The Test job filters out @t3tools/monorepo, whose own
test script is vp run -r test and would recurse — so the root package's
suites, scripts/ and the oxlint plugin, 396 tests, ran nowhere at all.

Adds a step that runs them directly, plus a vitest exclusion for a plain node
.cjs helper under .github/scripts/ that vitest would otherwise collect and
fail on with "No test suite found in file".

Verification

  • vp test run scripts/build-desktop-artifact.test.ts — 68 passed (was 67/1)
  • vp test run scripts oxlint-plugin-t3code396 passed, 35 files, so the
    new CI step is green today
  • Mutation probe: removing the arch gate
    (hostArchitecture !== input.targetArch) still fails the cross-architecture
    test, so the retargeted assertion is load-bearing rather than merely passing

Closes#147.

Claude Opus 5 via Claude Code.


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

…ites
scripts/build-desktop-artifact.test.ts has been failing on pylon. The
cross-architecture test asserted that no spawned command carried
ELECTRON_RUN_AS_NODE=1, but verifyWindowsPrimaryFffNativeLoad spreads
process.env into the child, so the assertion tripped whenever the runner itself
had that variable set - which is the case under any Electron-hosted shell. The
probe was correctly skipping the whole time.
Asserts what the test means instead: the packaged executable was never spawned.
That is the only thing the probe does, and it cannot be faked by an inherited
environment. Removing the arch gate still fails it.
Nobody noticed because CI never ran the file. The Test job filters out
@t3tools/monorepo, whose own test script is `vp run -r test` and would recurse,
so the root package's suites - scripts/ and the oxlint plugin, 396 tests - ran
nowhere. Adds a step that runs them directly, and excludes a plain node .cjs
helper under .github/scripts that vitest would otherwise collect and fail on.
Closes#147.
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S labels Aug 29, 2026
@github-actions

github-actionsBot commented Aug 29, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB+18 B (+0.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+2 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB+16 B (+0.2%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB55.5 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages990 (0.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB0 B (0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB+1 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 71a06e0 · PR result: 5678b0e · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar
rynfar merged commit 6a31ea8 into pylonAug 29, 2026
20 of 21 checks passed
@rynfar
rynfar deleted the fix/windows-native-probe-test branch August 29, 2026 05:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Svouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scripts/build-desktop-artifact.test.ts is failing on pylon

1 participant

@rynfar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(ci): repair the Windows probe test and actually run repository suites - #161

Merged
rynfar merged 1 commit into
pylonfrom
fix/windows-native-probe-test
Aug 29, 2026
Merged

fix(ci): repair the Windows probe test and actually run repository suites#161
rynfar merged 1 commit into
pylonfrom
fix/windows-native-probe-test

Conversation

@rynfar

@rynfarrynfar commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

scripts/build-desktop-artifact.test.ts has been failing on pylon:

× skips the primary native probe for cross-architecture Windows payloads
AssertionError: expected true to be false

The test was wrong, not the code

It asserted that no spawned command carried ELECTRON_RUN_AS_NODE=1. But
verifyWindowsPrimaryFffNativeLoad spreads process.env into the child, so that
assertion trips whenever the runner itself has the variable set — which is the
case under any Electron-hosted shell. The arch gate was skipping the probe
correctly the whole time; the test was reading an inherited environment variable
and calling it evidence.

It now asserts what it means: the packaged executable was never spawned.
That is the only thing the probe does, and it cannot be faked by inheritance.

Why nobody noticed

CI never ran the file. The Test job filters out @t3tools/monorepo, whose own
test script is vp run -r test and would recurse — so the root package's
suites, scripts/ and the oxlint plugin, 396 tests, ran nowhere at all.

Adds a step that runs them directly, plus a vitest exclusion for a plain node
.cjs helper under .github/scripts/ that vitest would otherwise collect and
fail on with "No test suite found in file".

Verification

  • vp test run scripts/build-desktop-artifact.test.ts — 68 passed (was 67/1)
  • vp test run scripts oxlint-plugin-t3code396 passed, 35 files, so the
    new CI step is green today
  • Mutation probe: removing the arch gate
    (hostArchitecture !== input.targetArch) still fails the cross-architecture
    test, so the retargeted assertion is load-bearing rather than merely passing

Closes#147.

Claude Opus 5 via Claude Code.


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

…ites
scripts/build-desktop-artifact.test.ts has been failing on pylon. The
cross-architecture test asserted that no spawned command carried
ELECTRON_RUN_AS_NODE=1, but verifyWindowsPrimaryFffNativeLoad spreads
process.env into the child, so the assertion tripped whenever the runner itself
had that variable set - which is the case under any Electron-hosted shell. The
probe was correctly skipping the whole time.
Asserts what the test means instead: the packaged executable was never spawned.
That is the only thing the probe does, and it cannot be faked by an inherited
environment. Removing the arch gate still fails it.
Nobody noticed because CI never ran the file. The Test job filters out
@t3tools/monorepo, whose own test script is `vp run -r test` and would recurse,
so the root package's suites - scripts/ and the oxlint plugin, 396 tests - ran
nowhere. Adds a step that runs them directly, and excludes a plain node .cjs
helper under .github/scripts that vitest would otherwise collect and fail on.
Closes#147.
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S labels Aug 29, 2026
@github-actions

github-actionsBot commented Aug 29, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB+18 B (+0.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+2 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB+16 B (+0.2%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB55.5 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages990 (0.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB0 B (0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB+1 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 71a06e0 · PR result: 5678b0e · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar
rynfar merged commit 6a31ea8 into pylonAug 29, 2026
20 of 21 checks passed
@rynfar
rynfar deleted the fix/windows-native-probe-test branch August 29, 2026 05:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Svouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scripts/build-desktop-artifact.test.ts is failing on pylon

1 participant

@rynfar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(ci): repair the Windows probe test and actually run repository suites - #161

Merged
rynfar merged 1 commit into
pylonfrom
fix/windows-native-probe-test
Aug 29, 2026
Merged

fix(ci): repair the Windows probe test and actually run repository suites#161
rynfar merged 1 commit into
pylonfrom
fix/windows-native-probe-test

Conversation

@rynfar

@rynfarrynfar commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

scripts/build-desktop-artifact.test.ts has been failing on pylon:

× skips the primary native probe for cross-architecture Windows payloads
AssertionError: expected true to be false

The test was wrong, not the code

It asserted that no spawned command carried ELECTRON_RUN_AS_NODE=1. But
verifyWindowsPrimaryFffNativeLoad spreads process.env into the child, so that
assertion trips whenever the runner itself has the variable set — which is the
case under any Electron-hosted shell. The arch gate was skipping the probe
correctly the whole time; the test was reading an inherited environment variable
and calling it evidence.

It now asserts what it means: the packaged executable was never spawned.
That is the only thing the probe does, and it cannot be faked by inheritance.

Why nobody noticed

CI never ran the file. The Test job filters out @t3tools/monorepo, whose own
test script is vp run -r test and would recurse — so the root package's
suites, scripts/ and the oxlint plugin, 396 tests, ran nowhere at all.

Adds a step that runs them directly, plus a vitest exclusion for a plain node
.cjs helper under .github/scripts/ that vitest would otherwise collect and
fail on with "No test suite found in file".

Verification

  • vp test run scripts/build-desktop-artifact.test.ts — 68 passed (was 67/1)
  • vp test run scripts oxlint-plugin-t3code396 passed, 35 files, so the
    new CI step is green today
  • Mutation probe: removing the arch gate
    (hostArchitecture !== input.targetArch) still fails the cross-architecture
    test, so the retargeted assertion is load-bearing rather than merely passing

Closes#147.

Claude Opus 5 via Claude Code.


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

…ites
scripts/build-desktop-artifact.test.ts has been failing on pylon. The
cross-architecture test asserted that no spawned command carried
ELECTRON_RUN_AS_NODE=1, but verifyWindowsPrimaryFffNativeLoad spreads
process.env into the child, so the assertion tripped whenever the runner itself
had that variable set - which is the case under any Electron-hosted shell. The
probe was correctly skipping the whole time.
Asserts what the test means instead: the packaged executable was never spawned.
That is the only thing the probe does, and it cannot be faked by an inherited
environment. Removing the arch gate still fails it.
Nobody noticed because CI never ran the file. The Test job filters out
@t3tools/monorepo, whose own test script is `vp run -r test` and would recurse,
so the root package's suites - scripts/ and the oxlint plugin, 396 tests - ran
nowhere. Adds a step that runs them directly, and excludes a plain node .cjs
helper under .github/scripts that vitest would otherwise collect and fail on.
Closes#147.
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S labels Aug 29, 2026
@github-actions

github-actionsBot commented Aug 29, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB+18 B (+0.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+2 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB+16 B (+0.2%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB55.5 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages990 (0.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB0 B (0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB+1 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 71a06e0 · PR result: 5678b0e · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar
rynfar merged commit 6a31ea8 into pylonAug 29, 2026
20 of 21 checks passed
@rynfar
rynfar deleted the fix/windows-native-probe-test branch August 29, 2026 05:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Svouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scripts/build-desktop-artifact.test.ts is failing on pylon

1 participant

@rynfar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(ci): repair the Windows probe test and actually run repository suites - #161

Merged
rynfar merged 1 commit into
pylonfrom
fix/windows-native-probe-test
Aug 29, 2026
Merged

fix(ci): repair the Windows probe test and actually run repository suites#161
rynfar merged 1 commit into
pylonfrom
fix/windows-native-probe-test

Conversation

@rynfar

@rynfarrynfar commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

scripts/build-desktop-artifact.test.ts has been failing on pylon:

× skips the primary native probe for cross-architecture Windows payloads
AssertionError: expected true to be false

The test was wrong, not the code

It asserted that no spawned command carried ELECTRON_RUN_AS_NODE=1. But
verifyWindowsPrimaryFffNativeLoad spreads process.env into the child, so that
assertion trips whenever the runner itself has the variable set — which is the
case under any Electron-hosted shell. The arch gate was skipping the probe
correctly the whole time; the test was reading an inherited environment variable
and calling it evidence.

It now asserts what it means: the packaged executable was never spawned.
That is the only thing the probe does, and it cannot be faked by inheritance.

Why nobody noticed

CI never ran the file. The Test job filters out @t3tools/monorepo, whose own
test script is vp run -r test and would recurse — so the root package's
suites, scripts/ and the oxlint plugin, 396 tests, ran nowhere at all.

Adds a step that runs them directly, plus a vitest exclusion for a plain node
.cjs helper under .github/scripts/ that vitest would otherwise collect and
fail on with "No test suite found in file".

Verification

  • vp test run scripts/build-desktop-artifact.test.ts — 68 passed (was 67/1)
  • vp test run scripts oxlint-plugin-t3code396 passed, 35 files, so the
    new CI step is green today
  • Mutation probe: removing the arch gate
    (hostArchitecture !== input.targetArch) still fails the cross-architecture
    test, so the retargeted assertion is load-bearing rather than merely passing

Closes#147.

Claude Opus 5 via Claude Code.


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

…ites
scripts/build-desktop-artifact.test.ts has been failing on pylon. The
cross-architecture test asserted that no spawned command carried
ELECTRON_RUN_AS_NODE=1, but verifyWindowsPrimaryFffNativeLoad spreads
process.env into the child, so the assertion tripped whenever the runner itself
had that variable set - which is the case under any Electron-hosted shell. The
probe was correctly skipping the whole time.
Asserts what the test means instead: the packaged executable was never spawned.
That is the only thing the probe does, and it cannot be faked by an inherited
environment. Removing the arch gate still fails it.
Nobody noticed because CI never ran the file. The Test job filters out
@t3tools/monorepo, whose own test script is `vp run -r test` and would recurse,
so the root package's suites - scripts/ and the oxlint plugin, 396 tests - ran
nowhere. Adds a step that runs them directly, and excludes a plain node .cjs
helper under .github/scripts that vitest would otherwise collect and fail on.
Closes#147.
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S labels Aug 29, 2026
@github-actions

github-actionsBot commented Aug 29, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB+18 B (+0.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+2 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB+16 B (+0.2%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB55.5 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages990 (0.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB0 B (0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB+1 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 71a06e0 · PR result: 5678b0e · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar
rynfar merged commit 6a31ea8 into pylonAug 29, 2026
20 of 21 checks passed
@rynfar
rynfar deleted the fix/windows-native-probe-test branch August 29, 2026 05:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Svouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scripts/build-desktop-artifact.test.ts is failing on pylon

1 participant

@rynfar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(ci): repair the Windows probe test and actually run repository suites - #161

Merged
rynfar merged 1 commit into
pylonfrom
fix/windows-native-probe-test
Aug 29, 2026
Merged

fix(ci): repair the Windows probe test and actually run repository suites#161
rynfar merged 1 commit into
pylonfrom
fix/windows-native-probe-test

Conversation

@rynfar

@rynfarrynfar commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

scripts/build-desktop-artifact.test.ts has been failing on pylon:

× skips the primary native probe for cross-architecture Windows payloads
AssertionError: expected true to be false

The test was wrong, not the code

It asserted that no spawned command carried ELECTRON_RUN_AS_NODE=1. But
verifyWindowsPrimaryFffNativeLoad spreads process.env into the child, so that
assertion trips whenever the runner itself has the variable set — which is the
case under any Electron-hosted shell. The arch gate was skipping the probe
correctly the whole time; the test was reading an inherited environment variable
and calling it evidence.

It now asserts what it means: the packaged executable was never spawned.
That is the only thing the probe does, and it cannot be faked by inheritance.

Why nobody noticed

CI never ran the file. The Test job filters out @t3tools/monorepo, whose own
test script is vp run -r test and would recurse — so the root package's
suites, scripts/ and the oxlint plugin, 396 tests, ran nowhere at all.

Adds a step that runs them directly, plus a vitest exclusion for a plain node
.cjs helper under .github/scripts/ that vitest would otherwise collect and
fail on with "No test suite found in file".

Verification

  • vp test run scripts/build-desktop-artifact.test.ts — 68 passed (was 67/1)
  • vp test run scripts oxlint-plugin-t3code396 passed, 35 files, so the
    new CI step is green today
  • Mutation probe: removing the arch gate
    (hostArchitecture !== input.targetArch) still fails the cross-architecture
    test, so the retargeted assertion is load-bearing rather than merely passing

Closes#147.

Claude Opus 5 via Claude Code.


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

…ites
scripts/build-desktop-artifact.test.ts has been failing on pylon. The
cross-architecture test asserted that no spawned command carried
ELECTRON_RUN_AS_NODE=1, but verifyWindowsPrimaryFffNativeLoad spreads
process.env into the child, so the assertion tripped whenever the runner itself
had that variable set - which is the case under any Electron-hosted shell. The
probe was correctly skipping the whole time.
Asserts what the test means instead: the packaged executable was never spawned.
That is the only thing the probe does, and it cannot be faked by an inherited
environment. Removing the arch gate still fails it.
Nobody noticed because CI never ran the file. The Test job filters out
@t3tools/monorepo, whose own test script is `vp run -r test` and would recurse,
so the root package's suites - scripts/ and the oxlint plugin, 396 tests - ran
nowhere. Adds a step that runs them directly, and excludes a plain node .cjs
helper under .github/scripts that vitest would otherwise collect and fail on.
Closes#147.
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S labels Aug 29, 2026
@github-actions

github-actionsBot commented Aug 29, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB+18 B (+0.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+2 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB+16 B (+0.2%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB55.5 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages990 (0.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB0 B (0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB+1 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 71a06e0 · PR result: 5678b0e · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar
rynfar merged commit 6a31ea8 into pylonAug 29, 2026
20 of 21 checks passed
@rynfar
rynfar deleted the fix/windows-native-probe-test branch August 29, 2026 05:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Svouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scripts/build-desktop-artifact.test.ts is failing on pylon

1 participant

@rynfar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(ci): repair the Windows probe test and actually run repository suites - #161

Merged
rynfar merged 1 commit into
pylonfrom
fix/windows-native-probe-test
Aug 29, 2026
Merged

fix(ci): repair the Windows probe test and actually run repository suites#161
rynfar merged 1 commit into
pylonfrom
fix/windows-native-probe-test

Conversation

@rynfar

@rynfarrynfar commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

scripts/build-desktop-artifact.test.ts has been failing on pylon:

× skips the primary native probe for cross-architecture Windows payloads
AssertionError: expected true to be false

The test was wrong, not the code

It asserted that no spawned command carried ELECTRON_RUN_AS_NODE=1. But
verifyWindowsPrimaryFffNativeLoad spreads process.env into the child, so that
assertion trips whenever the runner itself has the variable set — which is the
case under any Electron-hosted shell. The arch gate was skipping the probe
correctly the whole time; the test was reading an inherited environment variable
and calling it evidence.

It now asserts what it means: the packaged executable was never spawned.
That is the only thing the probe does, and it cannot be faked by inheritance.

Why nobody noticed

CI never ran the file. The Test job filters out @t3tools/monorepo, whose own
test script is vp run -r test and would recurse — so the root package's
suites, scripts/ and the oxlint plugin, 396 tests, ran nowhere at all.

Adds a step that runs them directly, plus a vitest exclusion for a plain node
.cjs helper under .github/scripts/ that vitest would otherwise collect and
fail on with "No test suite found in file".

Verification

  • vp test run scripts/build-desktop-artifact.test.ts — 68 passed (was 67/1)
  • vp test run scripts oxlint-plugin-t3code396 passed, 35 files, so the
    new CI step is green today
  • Mutation probe: removing the arch gate
    (hostArchitecture !== input.targetArch) still fails the cross-architecture
    test, so the retargeted assertion is load-bearing rather than merely passing

Closes#147.

Claude Opus 5 via Claude Code.


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

…ites
scripts/build-desktop-artifact.test.ts has been failing on pylon. The
cross-architecture test asserted that no spawned command carried
ELECTRON_RUN_AS_NODE=1, but verifyWindowsPrimaryFffNativeLoad spreads
process.env into the child, so the assertion tripped whenever the runner itself
had that variable set - which is the case under any Electron-hosted shell. The
probe was correctly skipping the whole time.
Asserts what the test means instead: the packaged executable was never spawned.
That is the only thing the probe does, and it cannot be faked by an inherited
environment. Removing the arch gate still fails it.
Nobody noticed because CI never ran the file. The Test job filters out
@t3tools/monorepo, whose own test script is `vp run -r test` and would recurse,
so the root package's suites - scripts/ and the oxlint plugin, 396 tests - ran
nowhere. Adds a step that runs them directly, and excludes a plain node .cjs
helper under .github/scripts that vitest would otherwise collect and fail on.
Closes#147.
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S labels Aug 29, 2026
@github-actions

github-actionsBot commented Aug 29, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB+18 B (+0.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+2 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB+16 B (+0.2%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB55.5 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages990 (0.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB0 B (0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB+1 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 71a06e0 · PR result: 5678b0e · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar
rynfar merged commit 6a31ea8 into pylonAug 29, 2026
20 of 21 checks passed
@rynfar
rynfar deleted the fix/windows-native-probe-test branch August 29, 2026 05:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Svouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scripts/build-desktop-artifact.test.ts is failing on pylon

1 participant

@rynfar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(ci): repair the Windows probe test and actually run repository suites - #161

Merged
rynfar merged 1 commit into
pylonfrom
fix/windows-native-probe-test
Aug 29, 2026
Merged

fix(ci): repair the Windows probe test and actually run repository suites#161
rynfar merged 1 commit into
pylonfrom
fix/windows-native-probe-test

Conversation

@rynfar

@rynfarrynfar commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

scripts/build-desktop-artifact.test.ts has been failing on pylon:

× skips the primary native probe for cross-architecture Windows payloads
AssertionError: expected true to be false

The test was wrong, not the code

It asserted that no spawned command carried ELECTRON_RUN_AS_NODE=1. But
verifyWindowsPrimaryFffNativeLoad spreads process.env into the child, so that
assertion trips whenever the runner itself has the variable set — which is the
case under any Electron-hosted shell. The arch gate was skipping the probe
correctly the whole time; the test was reading an inherited environment variable
and calling it evidence.

It now asserts what it means: the packaged executable was never spawned.
That is the only thing the probe does, and it cannot be faked by inheritance.

Why nobody noticed

CI never ran the file. The Test job filters out @t3tools/monorepo, whose own
test script is vp run -r test and would recurse — so the root package's
suites, scripts/ and the oxlint plugin, 396 tests, ran nowhere at all.

Adds a step that runs them directly, plus a vitest exclusion for a plain node
.cjs helper under .github/scripts/ that vitest would otherwise collect and
fail on with "No test suite found in file".

Verification

  • vp test run scripts/build-desktop-artifact.test.ts — 68 passed (was 67/1)
  • vp test run scripts oxlint-plugin-t3code396 passed, 35 files, so the
    new CI step is green today
  • Mutation probe: removing the arch gate
    (hostArchitecture !== input.targetArch) still fails the cross-architecture
    test, so the retargeted assertion is load-bearing rather than merely passing

Closes#147.

Claude Opus 5 via Claude Code.


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

…ites
scripts/build-desktop-artifact.test.ts has been failing on pylon. The
cross-architecture test asserted that no spawned command carried
ELECTRON_RUN_AS_NODE=1, but verifyWindowsPrimaryFffNativeLoad spreads
process.env into the child, so the assertion tripped whenever the runner itself
had that variable set - which is the case under any Electron-hosted shell. The
probe was correctly skipping the whole time.
Asserts what the test means instead: the packaged executable was never spawned.
That is the only thing the probe does, and it cannot be faked by an inherited
environment. Removing the arch gate still fails it.
Nobody noticed because CI never ran the file. The Test job filters out
@t3tools/monorepo, whose own test script is `vp run -r test` and would recurse,
so the root package's suites - scripts/ and the oxlint plugin, 396 tests - ran
nowhere. Adds a step that runs them directly, and excludes a plain node .cjs
helper under .github/scripts that vitest would otherwise collect and fail on.
Closes#147.
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S labels Aug 29, 2026
@github-actions

github-actionsBot commented Aug 29, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB+18 B (+0.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+2 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB+16 B (+0.2%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB55.5 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages990 (0.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB0 B (0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB+1 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 71a06e0 · PR result: 5678b0e · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar
rynfar merged commit 6a31ea8 into pylonAug 29, 2026
20 of 21 checks passed
@rynfar
rynfar deleted the fix/windows-native-probe-test branch August 29, 2026 05:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Svouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scripts/build-desktop-artifact.test.ts is failing on pylon

1 participant

@rynfar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(ci): repair the Windows probe test and actually run repository suites - #161

Merged
rynfar merged 1 commit into
pylonfrom
fix/windows-native-probe-test
Aug 29, 2026
Merged

fix(ci): repair the Windows probe test and actually run repository suites#161
rynfar merged 1 commit into
pylonfrom
fix/windows-native-probe-test

Conversation

@rynfar

@rynfarrynfar commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

scripts/build-desktop-artifact.test.ts has been failing on pylon:

× skips the primary native probe for cross-architecture Windows payloads
AssertionError: expected true to be false

The test was wrong, not the code

It asserted that no spawned command carried ELECTRON_RUN_AS_NODE=1. But
verifyWindowsPrimaryFffNativeLoad spreads process.env into the child, so that
assertion trips whenever the runner itself has the variable set — which is the
case under any Electron-hosted shell. The arch gate was skipping the probe
correctly the whole time; the test was reading an inherited environment variable
and calling it evidence.

It now asserts what it means: the packaged executable was never spawned.
That is the only thing the probe does, and it cannot be faked by inheritance.

Why nobody noticed

CI never ran the file. The Test job filters out @t3tools/monorepo, whose own
test script is vp run -r test and would recurse — so the root package's
suites, scripts/ and the oxlint plugin, 396 tests, ran nowhere at all.

Adds a step that runs them directly, plus a vitest exclusion for a plain node
.cjs helper under .github/scripts/ that vitest would otherwise collect and
fail on with "No test suite found in file".

Verification

  • vp test run scripts/build-desktop-artifact.test.ts — 68 passed (was 67/1)
  • vp test run scripts oxlint-plugin-t3code396 passed, 35 files, so the
    new CI step is green today
  • Mutation probe: removing the arch gate
    (hostArchitecture !== input.targetArch) still fails the cross-architecture
    test, so the retargeted assertion is load-bearing rather than merely passing

Closes#147.

Claude Opus 5 via Claude Code.


View with [code]smithAutofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

…ites
scripts/build-desktop-artifact.test.ts has been failing on pylon. The
cross-architecture test asserted that no spawned command carried
ELECTRON_RUN_AS_NODE=1, but verifyWindowsPrimaryFffNativeLoad spreads
process.env into the child, so the assertion tripped whenever the runner itself
had that variable set - which is the case under any Electron-hosted shell. The
probe was correctly skipping the whole time.
Asserts what the test means instead: the packaged executable was never spawned.
That is the only thing the probe does, and it cannot be faked by an inherited
environment. Removing the arch gate still fails it.
Nobody noticed because CI never ran the file. The Test job filters out
@t3tools/monorepo, whose own test script is `vp run -r test` and would recurse,
so the root package's suites - scripts/ and the oxlint plugin, 396 tests - ran
nowhere. Adds a step that runs them directly, and excludes a plain node .cjs
helper under .github/scripts that vitest would otherwise collect and fail on.
Closes#147.
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S labels Aug 29, 2026
@github-actions

github-actionsBot commented Aug 29, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB+18 B (+0.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+2 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB+16 B (+0.2%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB55.5 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages990 (0.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB0 B (0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB+1 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 71a06e0 · PR result: 5678b0e · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar
rynfar merged commit 6a31ea8 into pylonAug 29, 2026
20 of 21 checks passed
@rynfar
rynfar deleted the fix/windows-native-probe-test branch August 29, 2026 05:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:Svouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scripts/build-desktop-artifact.test.ts is failing on pylon

1 participant

@rynfar