Uh oh!
There was an error while loading. Please reload this page.
perf(build): stop unpacking node_modules wholesale from the Windows asar - #23
Merged
Conversation
…sar (#5877) Co-authored-by: tsouth89 <tsouth89@users.noreply.github.com> Co-authored-by: t3-code[bot] <t3-code[bot]@users.noreply.github.com> Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com> Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com> (cherry picked from commit 7e01d33f0eeb9435299791392d546756cc09c5d3)
Thread transfer impact
This comment will update automatically after the next completed run. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts upstream
#5877, which stops the Windows asar unpackingnode_moduleswholesale.What's here
The packager previously unpacked the entire
node_modulestree out of the asar on Windows. This computes the set of packages that genuinely must stay external at runtime and unpacks only those, adding a bundle self-check that fails the build if an external package's declared dependencies aren't themselves external.974 insertions, of which 361 are new tests: a new
scripts/lib/cli-external-packages.tsplus its test, and a substantial expansion ofbuild-desktop-artifact.Pylon ships Windows artifacts (
Pylon-${version}-${arch}), so this is a real win for Windows users rather than upstream-only housekeeping.Pylon adaptations
scripts/build-desktop-artifact.tsholds Pylon's desktop identity —com.pylon.code,com.pylon.code.nightly,Pylon (Nightly),Pylon-${version}-${arch}. I checked the diff specifically: none of those lines are touched. The cherry-pick is clean.Two small tidies:
t3code-bundle-selfcheck-. Nothing reads the name, so it's nowpylon-bundle-selfcheck-rather than adding a fresh T3 string.unicorn(no-useless-fallback-in-spread)three times (...(x ?? {})in a spread is redundant). Dropped the fallbacks so this doesn't reintroduce the lint noise we just cleared in chore(web): clear stale T3 test copy and two lint false positives #19.Verification
vp test runon both test files: 57 passed.@t3tools/desktopandt3: no errors.vp linton the changed files: clean.I cannot produce a Windows package from macOS, so the packaging behaviour itself is unverified locally — CI's
Release Smokeis the real gate here, and that's worth a look before merging given this touches release tooling.Model: Claude Opus 5. Harness: Claude Code.
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.