Skip to content

docs(agents): retire DEF-10, adopted as #235#236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rynfar merged 1 commit into from
Sep 1, 2026
Merged

docs(agents): retire DEF-10, adopted as #235 #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .agents/upstream-review.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3123,10 +3123,11 @@ that `#8734`, not `#8693`, is the correct base — re-checked DEF-7 and left it
open (nothing touched `desktop-macos-preview.yml`, and its 2026-11-01 floor is
unreached), and re-checked DEF-8: its blocking condition **has now cleared**,
since Expo SDK 57 merged as `eff44d0cf`, leaving only its 2026-09-05 floor. That
batch also opened DEF-10, which is unusual — approved work that was never
started, recorded here because it sits before the cursor and no commit range
will surface it again. Entries are
removed once adopted, skipped, or fixed._
batch also opened DEF-10 — approved work that was never started, recorded
because it sat before the cursor where no commit range would have surfaced it
again. It was adopted as `#235` and retired the same day, 2026-09-01; the
register did exactly its job, which was to stop it vanishing between sessions.
Entries are removed once adopted, skipped, or fixed._

Upstream work that has been reviewed and consciously _not_ adopted yet, with
the condition that should trigger a fresh look. Entries stay here until they
Expand All@@ -3137,11 +3138,10 @@ Every review must read this register before reporting new candidates,
re-evaluate each `Revisit when` against the current upstream head, and report
the outcome. See Phase 2.5 of the `review-t3-upstream` skill.

| ID | Upstream | Deferred on | Revisit when | Why deferred |
| ------ | ---------------------------------------------------------------------------------------- | ----------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| DEF-7 | `33b650a5b` / `#8243` — anonymous macOS preview DMG downloads | 2026-08-27 | Either premise changes. (a) Pylon decides to distribute unsigned preview builds publicly — an external tester programme, or a contributor who cannot use `gh run download`. (b) Upstream lifts the same-repo restriction or drops the `contents: write` publish job: check with `git log --oneline <cursor>..t3code-upstream/main -- .github/workflows/desktop-macos-preview.yml` and read any hit touching the `if:` guards or job permissions. Not before 2026-11-01 — neither premise moves on a weekly timescale, and this should not be re-litigated every review. | Adopted as `#111`, then reverted by `#113` the same day. The port was sound and its four review findings were fixed; the feature does not earn its cost here. Fork PRs cannot trigger it, `gh run download` covers the headless case, and Pylon Nightly covers merged builds — leaving one maintainer-only use against 210 lines of race-prone YAML, a `contents: write` token on a PR-triggered workflow, a publicly hosted unsigned binary, and a Releases widget on a repository that otherwise has none. If revived, start from `#111` plus the fixes in `9d112329e`, not from upstream. |
| DEF-8 | `1f8ed54ad` / `#8694` — mobile dev-client reload and Metro startup cost | 2026-08-29 | `#171` (Expo SDK 57) has merged: `git log --oneline origin/pylon --grep "Expo SDK 57"` returns a commit. Then split it: the dev-loop half (`--clear` removal, dev `appVersion` runtime policy, uniwind 1.11 plus its patch, hot-swappable atom runtime, fast-refresh hooks, docs) and the product half (ControlPill long-press with the `@react-native-menu/menu` native patch, `home-thread-navigation`, `remote-environment-projections`, and the `client-runtime` `connection/registry.ts` scope change that also affects web). Drop upstream's `AGENTS.md` and `test-t3-mobile` skill hunks; keep the `pylon-code-*` schemes in `package.json`. Not before 2026-09-05. | Its lockfile was generated on Expo 57 and RN 0.86 and only verified there; on `pylon` today it conflicts on `pnpm-workspace.yaml` (4.25.2 versus the 4.26.2 screens patch), `apps/mobile/package.json` scheme identity, the lock, and Pylon-owned docs. Both halves need a native rebuild. Reviewed 2026-08-29; not a fit to land ahead of the SDK upgrade it was built on. |
| DEF-10 | `e3dcc1615` / `#8843` + `f9137a0c8` — mobile composer attachment menu with video support | 2026-09-01 | Nothing external blocks it — this is approved work that was not started before the session ended, and it sits _before_ the cursor, so no future commit range will surface it. Start it directly. Check `git log --oneline origin/pylon --grep "#8843"` first in case a later session already landed it. One caveat to re-check at that point: `#233` placed `ComposerDictationPrimaryAction` into the toolbar's right-hand cluster, which is where DEF-8's ControlPill long-press patch also wants to live. | Approved in the same direction as the rest of the 2026-08-30 batch; integration simply never began. Recorded here rather than left in the batch table alone, because an approved-but-unstarted item that precedes the cursor is exactly the kind of work that gets lost. |
| ID | Upstream | Deferred on | Revisit when | Why deferred |
| ----- | ----------------------------------------------------------------------- | ----------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| DEF-7 | `33b650a5b` / `#8243` — anonymous macOS preview DMG downloads | 2026-08-27 | Either premise changes. (a) Pylon decides to distribute unsigned preview builds publicly — an external tester programme, or a contributor who cannot use `gh run download`. (b) Upstream lifts the same-repo restriction or drops the `contents: write` publish job: check with `git log --oneline <cursor>..t3code-upstream/main -- .github/workflows/desktop-macos-preview.yml` and read any hit touching the `if:` guards or job permissions. Not before 2026-11-01 — neither premise moves on a weekly timescale, and this should not be re-litigated every review. | Adopted as `#111`, then reverted by `#113` the same day. The port was sound and its four review findings were fixed; the feature does not earn its cost here. Fork PRs cannot trigger it, `gh run download` covers the headless case, and Pylon Nightly covers merged builds — leaving one maintainer-only use against 210 lines of race-prone YAML, a `contents: write` token on a PR-triggered workflow, a publicly hosted unsigned binary, and a Releases widget on a repository that otherwise has none. If revived, start from `#111` plus the fixes in `9d112329e`, not from upstream. |
| DEF-8 | `1f8ed54ad` / `#8694` — mobile dev-client reload and Metro startup cost | 2026-08-29 | `#171` (Expo SDK 57) has merged: `git log --oneline origin/pylon --grep "Expo SDK 57"` returns a commit. Then split it: the dev-loop half (`--clear` removal, dev `appVersion` runtime policy, uniwind 1.11 plus its patch, hot-swappable atom runtime, fast-refresh hooks, docs) and the product half (ControlPill long-press with the `@react-native-menu/menu` native patch, `home-thread-navigation`, `remote-environment-projections`, and the `client-runtime` `connection/registry.ts` scope change that also affects web). Drop upstream's `AGENTS.md` and `test-t3-mobile` skill hunks; keep the `pylon-code-*` schemes in `package.json`. Not before 2026-09-05. | Its lockfile was generated on Expo 57 and RN 0.86 and only verified there; on `pylon` today it conflicts on `pnpm-workspace.yaml` (4.25.2 versus the 4.26.2 screens patch), `apps/mobile/package.json` scheme identity, the lock, and Pylon-owned docs. Both halves need a native rebuild. Reviewed 2026-08-29; not a fit to land ahead of the SDK upgrade it was built on. |

## Upstream watch list

Expand Down
Loading