Uh oh!
There was an error while loading. Please reload this page.
fix(chat): smooth worktree setup and keep live activity visible - #239
Open
rynfar wants to merge 3 commits into
Open
fix(chat): smooth worktree setup and keep live activity visible#239rynfar wants to merge 3 commits into
rynfar wants to merge 3 commits into
Conversation
(cherry picked from commit ef84bc9873a6c4565fbeb64dce3f552570e95a2d)
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> (cherry picked from commit 9ecfc07a8b3acadd1612665b6e24425f625480de)
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> (cherry picked from commit 590a579f2e9292ce314c69e459e19620004578fe)
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third PR of the
9b2d04317..b883fc066batch. Three upstream commits, hand-merged — worktree setup no longer shows a jumping "Working for 0s", agent activity stays visible between actions, and a finished command stays live until the next one starts.#8922smooth worktree setup status#8984keep agent activity visible between actions#9098keep the latest command live between messagesSkipping a commit upstream reverted
#9062landed this behaviour and upstream reverted it 8 minutes later in#9096;#9098is the corrected re-land. Both#9062and its revert are skipped — only#9098is here. The delta shows the original bug: it reused the stableLIVE_ACTIVITY_ROW_IDeven when the group was not live, so the indicator vanished once a command finished.Pylon features kept
#8922and#9098both rewrite the working-indicator row that carries Pylon'sworkingStepLabel— the same field that was silently stripped once before and restored in #221. Upstream's version of that JSX has no equivalent and would have dropped it again.Resolved by taking upstream's structure (they remove an outer wrapper) and keeping Pylon's step-label span inside it.
workingStepLabel8 refs,activeTurnInProgress6,reportedCostLabel3 — all unchanged.ChatViewkeeps both its own props and upstream's newisPreparingWorktree;session-logickeeps Pylon's three skip conditions alongside upstream'sisWorktreeSetupActivityguard.Three test corrections, and one I got wrong
#8922pins the working row toh-6so the label swap cannot change row height. Pylon's assertion predated it — updated rather than loosened.#8984replaced the working row'sshowThinkingflag with a separatethinkingrow. My keep-both merge left a stale assertion on a property that no longer exists.#9098gives the Thinking row a brain glyph and tightens its padding topx-0.5, so the test named "aligns the iconless Thinking row" was asserting a premise that no longer holds. Renamed, and it now asserts the actual alignment contract: thesize-6icon box matching the working row'sh-6.I also briefly added a
lucide-xassertion to a test whose entire point is that the icon stays neutral on a trailing failure. The suite caught it immediately and it is reverted — the failure path is still covered at three other sites viatool call failed.Verification
@t3tools/webtypecheck clean, lint 0 errors, 642 tests passing. ZeroT3 Codein any added line.Reviewed and integrated with Claude Opus 5 in Claude Code.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.