Skip to content

Apply PEP 639 - #13014

Merged
nicoddemus merged 2 commits into
pytest-dev:mainfrom
nicoddemus:pep-693
Jul 26, 2025
Merged

Apply PEP 639#13014
nicoddemus merged 2 commits into
pytest-dev:mainfrom
nicoddemus:pep-693

Conversation

@nicoddemus

@nicoddemusnicoddemus commented Nov 30, 2024

Copy link
Copy Markdown
Member

@nicoddemus

nicoddemus commented Nov 30, 2024

Copy link
Copy Markdown
MemberAuthor

Thanks @hynek for sharing. 👍

@nicoddemus

nicoddemus commented Nov 30, 2024

Copy link
Copy Markdown
MemberAuthor

Hmmm seems like setuptools does not support this new format yet?

attrs uses hatch and the same configuration worked there.

@The-Compiler

The-Compiler commented Nov 30, 2024

Copy link
Copy Markdown
Member

Looks like it's WIP:

@nicoddemus

nicoddemus commented Nov 30, 2024

Copy link
Copy Markdown
MemberAuthor

Thanks @The-Compiler for looking into it.

Keeping this on-hold until a new version is released then.

@RonnyPfannschmidt

RonnyPfannschmidt commented Nov 30, 2024

Copy link
Copy Markdown
Member

Part of me would like to go hatch

@weiji14weiji14 mentioned this pull request Dec 19, 2024
Merged
7 tasks
@nicoddemus

nicoddemus commented Mar 1, 2025

Copy link
Copy Markdown
MemberAuthor

PR: pypa/setuptools#4829

bluetech
bluetech approved these changes Jun 18, 2025
View reviewed changes

@bluetechbluetech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good now. Will kick a rebase to make sure.

@RonnyPfannschmidtRonnyPfannschmidt added the skip news used on prs to opt out of the changelog requirement label Jun 18, 2025
RonnyPfannschmidt
RonnyPfannschmidt requested changes Jun 18, 2025
View reviewed changes

@RonnyPfannschmidtRonnyPfannschmidt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to set a higher minimum setuptools version

@bluetech

bluetech commented Jun 18, 2025

Copy link
Copy Markdown
Member

We need to set a higher minimum setuptools version

Right, went ahead and did it, hopefully @nicoddemus doesn't mind :)

@nicoddemus

nicoddemus commented Jul 24, 2025

Copy link
Copy Markdown
MemberAuthor

Right, went ahead and did it, hopefully @nicoddemus doesn't mind :)

Not at all of course, thanks!

Failure is due to:

tox-dev/tox#3565

@nicoddemus
nicoddemus enabled auto-merge (squash) July 26, 2025 01:09
@nicoddemus
nicoddemus merged commit 6773840 into pytest-dev:mainJul 26, 2025
36 checks passed
@nicoddemus
nicoddemus deleted the pep-693 branch July 26, 2025 01:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssbarneassbarneassbarnea approved these changes
@RonnyPfannschmidtRonnyPfannschmidtRonnyPfannschmidt approved these changes
@webknjazwebknjazwebknjaz approved these changes
@bluetechbluetechbluetech approved these changes

Assignees

No one assigned

Labels

skip newsused on prs to opt out of the changelog requirement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nicoddemus@The-Compiler@RonnyPfannschmidt@bluetech@ssbarnea@webknjaz