Uh oh!
There was an error while loading. Please reload this page.
Distribute first points in a BalancingLearner - #160
Conversation
akhmerov
commented
Mar 16, 2019
This fix seems to be only partial: consider for example the case when one learner is much cheaper than all the others. Then as soon as one point arrives, the balancing learner will request all points from another random learner in the queue. If I understand correctly, an empty learner has both an infinite loss and an infinite loss improvement, however some non-empty learners also have the same loss and loss improvement. In that case the problem would arise as well. Therefore it seems to suggest that a better fix would be to sort on |
basnijholt
commented
Mar 17, 2019
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
6e172ef to
eaa1911Compareakhmerov
commented
Mar 17, 2019
My problem right now is that the logic is rather nontrivial, and it's hard to follow especially due to very similar variable names. Comments might also help. |
9435ddc to
7af0f0bCompare8025f97 to
49e73f7Comparebasnijholt
commented
Mar 17, 2019
I found another issue that I fixed. I've simplified it now and I think the code is understandable, do you agree? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
b0e8d22 to
d9ceaf7CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
b0f5dd4 to
70712e4Compare70712e4 to
b2d13a9CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This fixes#159.
@akhmerov could you take a look at this?