Uh oh!
There was an error while loading. Please reload this page.
use setup(..., python_requires='>=3.6'), closes #179 - #180
Merged
Conversation
akhmerov
commented
Apr 3, 2019
Contributor
I see the following in py27: pipinstallgit+https://github.com/python-adaptive/adaptive.git@python_requires (py27) Collectinggit+https://github.com/python-adaptive/adaptive.git@python_requiresCloninghttps://github.com/python-adaptive/adaptive.git (torevisionpython_requires) to/tmp/pip-req-build-uRyzYICompleteoutputfromcommandpythonsetup.pyegg_info:
Traceback (mostrecentcalllast):
File"<string>", line1, in<module>File"/tmp/pip-req-build-uRyzYI/setup.py", line19, in<module>version, cmdclass=get_version_and_cmdclass('adaptive')
File"/tmp/pip-req-build-uRyzYI/setup.py", line11, inget_version_and_cmdclassfromimportlib.utilimportmodule_from_spec, spec_from_file_locationImportError: Nomodulenamedutil----------------------------------------Command"python setup.py egg_info"failedwitherrorcode1in/tmp/pip-req-build-uRyzYI/ |
Carreau
reviewed
Apr 3, 2019
| print('adaptive requires Python 3.6 or above.') | ||
| sys.exit(1) | ||
There was a problem hiding this comment.
Both are not incompatible. This check is still useful if you have users with pip < 9.0.1 (which is still often the case for Python 2 users).
basnijholt
commented
Apr 4, 2019
MemberAuthor
Thanks for checking, I've reverted that change. |
akhmerov
commented
Apr 4, 2019
Contributor
LGTM. pip still fails on 2.7 if installing from source, but that's an unrelated issue which we should fix separately. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As by the suggestion of @Carreau in #179.