Skip to content

use setup(..., python_requires='>=3.6'), closes #179 - #180

Merged
basnijholt merged 1 commit into
masterfrom
python_requires
Apr 4, 2019
Merged

use setup(..., python_requires='>=3.6'), closes #179#180
basnijholt merged 1 commit into
masterfrom
python_requires

Conversation

@basnijholt

Copy link
Copy Markdown
Member

As by the suggestion of @Carreau in #179.

@akhmerov

Copy link
Copy Markdown
Contributor

I see the following in py27:

pipinstallgit+https://github.com/python-adaptive/adaptive.git@python_requires (py27) Collectinggit+https://github.com/python-adaptive/adaptive.git@python_requiresCloninghttps://github.com/python-adaptive/adaptive.git (torevisionpython_requires) to/tmp/pip-req-build-uRyzYICompleteoutputfromcommandpythonsetup.pyegg_info:
Traceback (mostrecentcalllast):
File"<string>", line1, in<module>File"/tmp/pip-req-build-uRyzYI/setup.py", line19, in<module>version, cmdclass=get_version_and_cmdclass('adaptive')
File"/tmp/pip-req-build-uRyzYI/setup.py", line11, inget_version_and_cmdclassfromimportlib.utilimportmodule_from_spec, spec_from_file_locationImportError: Nomodulenamedutil----------------------------------------Command"python setup.py egg_info"failedwitherrorcode1in/tmp/pip-req-build-uRyzYI/

Comment threadsetup.py
print('adaptive requires Python 3.6 or above.')
sys.exit(1)


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are not incompatible. This check is still useful if you have users with pip < 9.0.1 (which is still often the case for Python 2 users).

@basnijholt

Copy link
Copy Markdown
MemberAuthor

Thanks for checking, I've reverted that change.

@akhmerov

Copy link
Copy Markdown
Contributor

LGTM. pip still fails on 2.7 if installing from source, but that's an unrelated issue which we should fix separately.

@basnijholt
basnijholt merged commit e1e3527 into masterApr 4, 2019
@basnijholtbasnijholt mentioned this pull request May 6, 2019
@basnijholt
basnijholt deleted the python_requires branch May 8, 2019 23:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@basnijholt@akhmerov@Carreau