Skip to content

Add option to display a progress bar when loading a BalancingLearner - #197

Closed
basnijholt wants to merge 1 commit into
stable-0.8from
with_progress_bar
Closed

Add option to display a progress bar when loading a BalancingLearner#197
basnijholt wants to merge 1 commit into
stable-0.8from
with_progress_bar

Conversation

@basnijholt

Copy link
Copy Markdown
Member

This adds an option with_progress_bar to the BalancingLearner.load method.

Output example
image

I am currently trying to load 370k learners which takes more than 30 min on a slow NFS. It would be really useful to display the progress.

@akhmerov

Copy link
Copy Markdown
Contributor

I think it's a bad design to expose this to a library user: a good interface should be simple, and this is a customizable non-essential functionality that also adds an extra dependency.

@jbweston

Copy link
Copy Markdown
Contributor

I agree with Anton; I think that this is a functionality that you could implement independently from the library (given that load is very simple)

@basnijholt

Copy link
Copy Markdown
MemberAuthor

Thanks for your feedback, I've added it to adaptive-scheduler where it makes more sense because you are dealing with many learners there.

@basnijholt
basnijholt deleted the with_progress_bar branch June 20, 2019 22:34
@basnijholtbasnijholt mentioned this pull request Aug 31, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@basnijholt@akhmerov@jbweston