Uh oh!
There was an error while loading. Please reload this page.
Conversation
akhmerov
commented
Jun 24, 2019
Contributor
I believe, authors check should be a part of the linting pipeline. Let's move it there. |
basnijholt
commented
Jun 24, 2019
MemberAuthor
It already is in the linting pipeline. |
akhmerov
commented
Jun 24, 2019
Contributor
@jbweston what's your opinion specifically on the proposed reorganization of the authors file? (that's the main decision to be made here) |
jbweston
commented
Jul 2, 2019
Contributor
I'm fine with the Authors file reorg |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#201 failed because of a missing author.
This PR allows the author test to fail and separates current maintainers from contributors.
ContinueOnError: trueis the same as WarnAndContinue.