Skip to content

add support for loky - #263

Merged
basnijholt merged 12 commits into
masterfrom
support-loky
Apr 10, 2020
Merged

add support for loky#263
basnijholt merged 12 commits into
masterfrom
support-loky

Conversation

@basnijholt

@basnijholtbasnijholt commented Apr 9, 2020•
edited by jbweston
Loading

Copy link
Copy Markdown
Member

Description

This adds support for loky which has a ProcessPoolExecutor that can for example use cloudpickle.

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@basnijholt
basnijholt requested a review from jbwestonApril 9, 2020 16:15
@codecov-io

codecov-io commented Apr 9, 2020•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #263 into master will increase coverage by 0.02%.
The diff coverage is 75.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #263 +/- ##
==========================================
+ Coverage 79.42% 79.44% +0.02% 
==========================================
Files 32 32 Lines 4403 4423 +20 Branches 811 815 +4 ==========================================
+ Hits 3497 3514 +17 - Misses 778 781 +3 
Partials 128 128
Impacted FilesCoverage Δ
adaptive/runner.py65.18% <64.70%> (-0.58%)⬇️
adaptive/tests/test_runner.py92.20% <100.00%> (+0.77%)⬆️
adaptive/learner/learner2D.py78.38% <0.00%> (+0.36%)⬆️
adaptive/learner/learner1D.py92.33% <0.00%> (+0.61%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b5620...db051be. Read the comment docs.

@basnijholtbasnijholt mentioned this pull request Apr 9, 2020
Merged
2 tasks
basnijholt
basnijholt commented Apr 9, 2020
View reviewed changes
Comment threadadaptive/runner.py
jbweston
jbweston approved these changes Apr 9, 2020
View reviewed changes

@jbwestonjbweston left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo test failures

Comment threadadaptive/runner.py
Comment threadadaptive/runner.py
@basnijholtbasnijholt mentioned this pull request Apr 9, 2020
Open
@basnijholt

basnijholt commented Apr 9, 2020

Copy link
Copy Markdown
MemberAuthor

I've opened joblib/loky#240.

@basnijholt

basnijholt commented Apr 10, 2020•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@jbweston, I think the remaining failures are related to https://bugs.python.org/issue36281 and #156.

Not sure how to tackle these.

I've opened joblib/loky#241.

@basnijholtbasnijholt mentioned this pull request Apr 10, 2020
Closed
@basnijholt
basnijholt merged commit df91ebb into masterApr 10, 2020
@basnijholt
basnijholt deleted the support-loky branch April 18, 2020 13:51
@basnijholtbasnijholt mentioned this pull request May 19, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbwestonjbwestonjbweston approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@basnijholt@codecov-io@jbweston