Skip to content

make the Runner work with unhashable points - #268

Merged
basnijholt merged 15 commits into
masterfrom
unhashable-runner-points
Apr 24, 2020
Merged

make the Runner work with unhashable points#268
basnijholt merged 15 commits into
masterfrom
unhashable-runner-points

Conversation

@basnijholt

@basnijholtbasnijholt commented Apr 16, 2020

Copy link
Copy Markdown
Member

Description

Enable the Runner to with with unhashable points.

Fixes#267.

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@basnijholt
basnijholtforce-pushed the unhashable-runner-points branch 3 times, most recently from 7e96a7c to 8a0adf3CompareApril 16, 2020 18:11
@basnijholtbasnijholt changed the title WIP: make the Runner work with unhashable pointsmake the Runner work with unhashable pointsApr 16, 2020
Comment threadadaptive/runner.py Outdated
Comment threadadaptive/runner.py Outdated
@codecov-io

codecov-io commented Apr 17, 2020

Copy link
Copy Markdown

Codecov Report

Merging #268 into master will decrease coverage by 0.17%.
The diff coverage is 50.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #268 +/- ##
==========================================
- Coverage 79.52% 79.35% -0.18% 
==========================================
Files 32 32 Lines 4425 4446 +21 Branches 815 821 +6 ==========================================
+ Hits 3519 3528 +9 - Misses 779 788 +9 - Partials 127 130 +3 
Impacted FilesCoverage Δ
adaptive/runner.py64.58% <50.00%> (-1.71%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0b22ff...62e9a41. Read the comment docs.

@basnijholt
basnijholtforce-pushed the unhashable-runner-points branch from 33800c8 to 79a804dCompareApril 20, 2020 12:25
@jbweston

Copy link
Copy Markdown
Contributor

I've scheduled time later this morning (pacific time) to take a look at this.

@jbwestonjbweston left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I agree with the approach, but I believe that we can make everything cleaner by only dealing with point IDs inside the runner itself. We only need to extract actual points at the interface between the runner and the outside world (when calling self.learner.ask and self._submit)

Comment threadadaptive/runner.py Outdated
Comment threadadaptive/runner.py Outdated
Comment threadadaptive/runner.py Outdated
Comment threadadaptive/runner.py Outdated
Comment threadadaptive/runner.py Outdated
Comment threadadaptive/runner.py Outdated
@basnijholt
basnijholtforce-pushed the unhashable-runner-points branch from 79a804d to 62e9a41CompareApril 22, 2020 18:37
@basnijholt

Copy link
Copy Markdown
MemberAuthor

@jbweston, thanks a lot for your review!

I've implemented all suggestions you've made 🎉

Comment threadadaptive/runner.py Outdated
Comment threadadaptive/runner.py

@jbwestonjbweston left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work

@basnijholt
basnijholtforce-pushed the unhashable-runner-points branch from 6ed7f85 to c7a12a4CompareApril 24, 2020 16:06
@basnijholt
basnijholt merged commit 5754320 into masterApr 24, 2020
basnijholt added a commit that referenced this pull request Apr 24, 2020
@basnijholtbasnijholt mentioned this pull request May 19, 2020
@basnijholt
basnijholt deleted the unhashable-runner-points branch May 20, 2020 08:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Runner work with unhashable points

4 participants

@basnijholt@codecov-io@jbweston@akhmerov