Uh oh!
There was an error while loading. Please reload this page.
make the Runner work with unhashable points - #268
Conversation
7e96a7c to
8a0adf3CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #268 +/- ##
==========================================
- Coverage 79.52% 79.35% -0.18%
==========================================
Files 32 32 Lines 4425 4446 +21 Branches 815 821 +6 ==========================================
+ Hits 3519 3528 +9 - Misses 779 788 +9 - Partials 127 130 +3
Continue to review full report at Codecov.
|
33800c8 to
79a804dComparejbweston
commented
Apr 22, 2020
I've scheduled time later this morning (pacific time) to take a look at this. |
jbweston
left a comment
There was a problem hiding this comment.
Overall I agree with the approach, but I believe that we can make everything cleaner by only dealing with point IDs inside the runner itself. We only need to extract actual points at the interface between the runner and the outside world (when calling self.learner.ask and self._submit)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
79a804d to
62e9a41Comparebasnijholt
commented
Apr 22, 2020
@jbweston, thanks a lot for your review! I've implemented all suggestions you've made 🎉 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
6ed7f85 to
c7a12a4Compare
Description
Enable the
Runnerto with with unhashable points.Fixes#267.
Checklist
pre-commit run --all(first install usingpip install pre-commit)pytestpassedType of change
Check relevant option(s).