Skip to content

Make LearnerND pickleable - #272

Merged
basnijholt merged 8 commits into
masterfrom
pickle-LearnerND
Sep 10, 2021
Merged

Make LearnerND pickleable#272
basnijholt merged 8 commits into
masterfrom
pickle-LearnerND

Conversation

@basnijholt

Copy link
Copy Markdown
Member

Description

This makes the LearnerND pickleable.

Other learners have been made pickleable in #264.

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@basnijholtbasnijholt mentioned this pull request Apr 23, 2020
6 tasks
@codecov-commenter

codecov-commenter commented Aug 30, 2021

Copy link
Copy Markdown

Codecov Report

Merging #272 (90b250b) into master (c820704) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #272 +/- ##
==========================================
- Coverage 80.72% 80.72% -0.01% 
==========================================
Files 38 38 Lines 5018 5022 +4 Branches 918 918 ==========================================
+ Hits 4051 4054 +3 - Misses 822 823 +1 
Partials 145 145 
Impacted FilesCoverage Δ
adaptive/tests/test_pickling.py88.67% <ø> (ø)
adaptive/learner/base_learner.py84.09% <100.00%> (ø)
adaptive/learner/learnerND.py60.19% <100.00%> (+0.50%)⬆️
adaptive/learner/average_learner1D.py78.88% <0.00%> (-0.75%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c820704...90b250b. Read the comment docs.

@basnijholtbasnijholt changed the title WIP: Make LearnerND pickleableMake LearnerND pickleableAug 30, 2021
@basnijholt
basnijholt merged commit 20e5986 into masterSep 10, 2021
@basnijholt
basnijholt deleted the pickle-LearnerND branch September 10, 2021 12:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@basnijholt@codecov-commenter@akhmerov