Skip to content

Provide a way of checking if the catalogs are up-to-date - #831

Merged
akx merged 2 commits into
python-babel:masterfrom
kjagiello:update-check
Apr 8, 2022
Merged

Provide a way of checking if the catalogs are up-to-date#831
akx merged 2 commits into
python-babel:masterfrom
kjagiello:update-check

Conversation

@kjagiello

@kjagiellokjagiello commented Jan 26, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

I was missing a way to, as a part of CI-pipeline, check if the translations files are up to date. This PRs attempts to implement it in form of a --check flag for pybabel update.

kjagiello
kjagiello commented Jan 26, 2022
View reviewed changes
Comment threadbabel/messages/catalog.py Outdated
kjagiello
kjagiello commented Jan 26, 2022
View reviewed changes
Comment threadbabel/messages/frontend.py Outdated
@akx
akx self-requested a review January 26, 2022 19:04
akx
akx requested changes Jan 28, 2022
View reviewed changes

@akxakx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, seems like a good addition. Some comments around naming and so on...

Comment threadbabel/messages/catalog.py Outdated
Comment threadbabel/messages/catalog.py Outdated
Comment threadbabel/messages/catalog.py Outdated
Comment threadbabel/messages/frontend.py Outdated
Comment threadbabel/messages/catalog.py Outdated
akx
akx requested changes Jan 29, 2022
View reviewed changes

@akxakx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in is_identical... :)

Comment threadbabel/messages/catalog.py Outdated
@kjagiello

kjagiello commented Feb 8, 2022

Copy link
Copy Markdown
ContributorAuthor

@akx Let me know if there is anything else that needs to be taken care of before we can merge this PR

@akx
akx self-requested a review February 20, 2022 14:57
akx
akx requested changes Apr 8, 2022
View reviewed changes

@akxakx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! Could you rebase this?

@kjagiello

kjagiello commented Apr 8, 2022

Copy link
Copy Markdown
ContributorAuthor

Sure thing, done!

@akx

akx commented Apr 8, 2022

Copy link
Copy Markdown
Member

@kjagiello Tests are unhappy 😭

@kjagiello

kjagiello commented Apr 8, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

This will hopefully do the trick! Forgot to do init.

@codecov

codecovBot commented Apr 8, 2022•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #831 (1f46a54) into master (4a6e86f) will increase coverage by 0.02%.
The diff coverage is 89.18%.

@@ Coverage Diff @@## master #831 +/- ##
==========================================
+ Coverage 91.09% 91.12% +0.02% 
==========================================
Files 23 23 Lines 4156 4190 +34 ==========================================
+ Hits 3786 3818 +32 - Misses 370 372 +2
Impacted FilesCoverage Δ
babel/messages/frontend.py86.32% <84.61%> (+0.22%)⬆️
babel/messages/catalog.py95.43% <100.00%> (+0.13%)⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

akx
akx approved these changes Apr 8, 2022
View reviewed changes

@akxakx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akx
akx merged commit d2d88da into python-babel:masterApr 8, 2022
This was referenced Jul 31, 2026
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akxakxakx approved these changes

Assignees

No one assigned

Labels

area/messagesenhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kjagiello@akx