Uh oh!
There was an error while loading. Please reload this page.
rearrange code to make PyPy testing happier - #59
Merged
Conversation
arigo
commented
Feb 15, 2024
Contributor
A bit confused: I thought that the check you mention is disabled by now. If it isn't, then is this commit enough? I had to do a couple more tweaks, like disabling the tests that end up calling this function... You are you talking about |
mattip
commented
Feb 15, 2024
ContributorAuthor
Yes, this is for the untranslated PyPy |
arigo
commented
Feb 15, 2024
Contributor
I'd consider skipping that test instead... |
mattip
commented
Feb 15, 2024
ContributorAuthor
I could skip it. But on the other hand, this is a pretty simple change to allow the test to keep running. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyPy testing has a check that the file
src/c/test_c.pyis properly synced to the PyPy version. It checks only code below the# __________________marker. The_assert_unraisablefunction added in #24 needs a bit of work to support all the python versions supported by PyPy (specifically, PyPy still uses python2.7) so it should appear above the marker.The change should be harmless in this repo since it is "only" a rearrangement of code.
cc @arigo