Skip to content

Update conditional pyreadline3 dependency for Win - #1046

Merged
tleonhardt merged 1 commit into
python-cmd2:masterfrom
KyleKing:patch-1
Jan 29, 2021
Merged

Update conditional pyreadline3 dependency for Win#1046
tleonhardt merged 1 commit into
python-cmd2:masterfrom
KyleKing:patch-1

Conversation

@KyleKing

Copy link
Copy Markdown
Contributor

Fixes#1025

@KyleKing

KyleKing commented Jan 26, 2021

Copy link
Copy Markdown
ContributorAuthor

The Azure Pipeline tests appear to be failing due to a HTTP 400 on uploading the codecov report. Otherwise those tests pass

==> Uploading
.url https://codecov.io
.query commit=b45d3d92c536317c47203250924dc080ed659cdf&branch=HEAD&package=py2.1.11
Gzipping contents..
Compressed contents to 14885 bytes
Pinging Codecov...
Error: HTTP 400
Please provide the repository token to upload reports via `-t :repository-token`

I'll look into and fix the AppVeyor build, which reported an error that readline was undefined

@KyleKing
KyleKing marked this pull request as draft January 26, 2021 03:03
@codecov

codecovBot commented Jan 27, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1046 (a96c0f5) into master (44eb9d4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #1046 +/- ##
=======================================
Coverage 97.92% 97.92% =======================================
Files 22 22 Lines 4619 4619 =======================================
Hits 4523 4523 Misses 96 96 
Impacted FilesCoverage Δ
cmd2/rl_utils.py100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44eb9d4...a96c0f5. Read the comment docs.

@KyleKing
KyleKing marked this pull request as ready for review January 28, 2021 00:17
@KyleKing

KyleKing commented Jan 28, 2021

Copy link
Copy Markdown
ContributorAuthor

I think this is ready for review! I collapsed the commit into a single one

Let me know if you want me to make any changes

(Also I'm not sure if continuous-integration/appveyor/branch will run? I left it for 24 hours with my initial commits before compacting the changes into one and it didn't update)

@tleonhardttleonhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the CHANGELOG, but that can be done after this merges in

@tleonhardt

Copy link
Copy Markdown
Member

Thanks for the PR @KyleKing !

@tleonhardt
tleonhardt merged commit d5cebae into python-cmd2:masterJan 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pyreadline

3 participants

@KyleKing@tleonhardt@kmvanbrunt