Uh oh!
There was an error while loading. Please reload this page.
Change synthesis.py to numpydoc style - #212
Merged
bnavigator merged 2 commits intoJan 7, 2024
Merged
Conversation
10 tasks
KybernetikJoforce-pushed
the
numpydoc_synthesis_py
branch
2 times, most recently
from
January 7, 2024 14:26
def6f95 to
8b21b5bCompareKybernetikJoforce-pushed
the
numpydoc_synthesis_py
branch
from
January 7, 2024 16:16
8b21b5b to
cbd4435CompareKybernetikJo
commented
Jan 7, 2024
ContributorAuthor
The test coverage drops, because the routine sb10jd has been added to init.py, but there is no pytest for it. |
KybernetikJo
marked this pull request as ready for review
January 7, 2024 16:19
KybernetikJo
marked this pull request as draft
January 7, 2024 16:20
KybernetikJo
marked this pull request as ready for review
January 7, 2024 16:25
bnavigator
commented
Jan 7, 2024
Collaborator
It's actually because of the removal of the last The following block is not covered properly. Lines 104 to 114 in 5b65877 This is outside of the scope of this PR. |
bnavigator
commented
Jan 7, 2024
Collaborator
Thanks a lot @KybernetikJo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
Slycot/slycot/synthesis.pyin order to be closer to the numpydoc style as discussed in #100.Should be part of #204.
Remark:
The synthesis.py has already been quite close to numpydoc before this PR. There must have been major cleanups in the past.
(finished 18 of 18 = (17 + 1) routines)
Status description: