Skip to content

Fixing testtsdb.py unit test - #671

Open
ajkumarnv wants to merge 6 commits into
python-diamond:masterfrom
ajkumarnv:master
Open

Fixing testtsdb.py unit test#671
ajkumarnv wants to merge 6 commits into
python-diamond:masterfrom
ajkumarnv:master

Conversation

@ajkumarnv

Copy link
Copy Markdown

Some tests for testtsdb.py are failing occasionally as we are comparing the mock_urlopen call args against a string . json.dumps behavior is sometimes unpredictable so string comparison at times fails. Changed to code the do json.load from the args and compare it against the list rather than string

@ajkumarnv

Copy link
Copy Markdown
Author

Some tests for testtsdb.py are failing occasionally as we are comparing the mock_urlopen call args against a string . json.dumps behavior is sometimes unpredictable so string comparison at times fails. Changed to code the do json.load from the args and compare it against the list rather than string

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 24.667% when pulling 404ef10 on ajkumarnv:master into f2bece4 on python-diamond:master.

@coveralls

coveralls commented Aug 7, 2017

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 24.667% when pulling 404ef10 on ajkumarnv:master into f2bece4 on python-diamond:master.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ajkumarnv@coveralls@shortdudey123