Skip to content
This repository was archived by the owner on Mar 14, 2021. It is now read-only.

Team 2 - #18

Open
RohanJnr wants to merge 32 commits into
python-discord:masterfrom
RohanJnr:Iceman
Open

Team 2#18
RohanJnr wants to merge 32 commits into
python-discord:masterfrom
RohanJnr:Iceman

Conversation

@RohanJnr

Copy link
Copy Markdown

ok still need editing ,the random name meathod still need editing :)

@gdude2002gdude2002 changed the title Iceman-Rags team 2 !!Team 2Mar 24, 2018
Comment threadbot/cogs/snakes.py
self.bot = bot

async def get_snek(self, name: str = None) -> Dict[str, Any]:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space here that should be removed

Comment threadbot/cogs/snakes.py

@command(name="get")
async def get(self, ctx: Context):#, name: str = None):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data retrieval needs to be in the get_snek() method.

Comment threadbot/cogs/snakes.py Outdated
# Any additional commands can be placed here. Be creative, but keep it to a reasonable amount!

@command(name="snakerandom")
async def SnakeRandom(self, ctx: Context, name: str = None):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to be using snake_case for the function name here.

Comment threadbot/cogs/snakes.py Outdated
@command(name="snakerandom")
async def SnakeRandom(self, ctx: Context, name: str = None):
# snakes=['Cobra','Python','Anaconda','Black Mamba','Rattle Snake']
randsnake = random.choice(['cobra', 'python', 'black mamba'])

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do with a few more snakes :P

Comment threadbot/cogs/snakes.py Outdated
embed.add_field(name="Expectation", value=f"@{ctx.author} expected {name}", inline=False)

if randsnake == "python":

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra blank line here, should be removed

Comment threadbot/cogs/snakes.py Outdated

if randsnake == "python":

return await ctx.send("Your a lucky dude !", embed=embed)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, extra space before the ! should be removed

Comment threadbot/cogs/snakes.py Outdated
return await ctx.send("Shiny liitle fella !", embed=embed)

@command(name="randname")
async def RandName(self, ctx: Context, name: str = None):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use snake_case here

Comment threadbot/cogs/snakes.py
p = len(name)
result = ""
front_back = 1
if front_back == 1: # so the users name is substring from the front and snake random substring from back

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be clearer with a blank line above this

Comment threadPipfile Outdated
aiohttp = "<2.3.0,>=2.0.0"
websockets = ">=4.0,<5.0"
wikipedia = "*"
wikiapi = "*"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you guys using these modules? If not, please pipenv uninstall them.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@RohanJnr@gdude2002@LaVieEstDure