Skip to content
This repository was archived by the owner on Mar 31, 2020. It is now read-only.

Wild Whispers - #13

Closed
JonasKs wants to merge 64 commits into
python-discord:masterfrom
JonasKs:master
Closed

Wild Whispers#13
JonasKs wants to merge 64 commits into
python-discord:masterfrom
JonasKs:master

Conversation

@JonasKs

@JonasKsJonasKs commented Feb 22, 2019

Copy link
Copy Markdown

No description provided.

JonasKsand others added 30 commits February 22, 2019 11:31
@JonasKs
Update README.md with some basic Project Information
61cf90a
This commit is mainly done in order to have a diff between the source branch and our fork, so that we are able to do a PR to the main project.
@JonasKs
Added teamleader to the README.md
9824a32
Commit mainly done to test webhook integration.
zeljkobekcic
Getting weather is now possible
4c5eedb
zeljkobekcic
Cleaning imports
748096f
zeljkobekcic
Fixing my name
5942fd1
zeljkobekcic
Fixing linting errors
e37c461
zeljkobekcic
Fixing linting errors
35ad8bd
@Supalien
push it, push it, push it
e76c3b9
@Supalien
removed test lines
5bbbc3c
@Supalien
The program now annoys you!
7312f98
@Supalien
Merge
470e9c0
@Supalien
added 'pillow = *' to Pipfile under [packages]
1f67b21
@Supalien
Added __init__.py to /project/frontend/ so python would treat it well.
8f14081
@Supalien
Linted the code so it would be readable by hoomans.
6a5e7a9
@V1CT0RIX
Fixed a bug when the search bar moved when it shouldnt
1335fc3
@Supalien
Revert "Fixed a bug when the search bar moved when it shouldnt"
dd1c764
This reverts commit 1335fc3.
@Supalien
Fixed a bug where the search bar moved when it shouldnt.
b5f8c71
@Supalien
added 2 boxes under the search bar, one for "Today" and one for "tomo…
88dcf96
…rrow".
zeljkobekcic
Merge branch 'master' of github.com:JonasKs/code-jam-4 into location_…
5036f94
…ambiguity
zeljkobekcic
Can now do stuff with similar city names
0aab7be
zeljkobekcic
Adding the weather status to the weather fetcher
bbe1660
zeljkobekcic
Updating the installation steps
0c3e586
zeljkobekcic
Fixing the language enviroment in the readme
056742c
zeljkobekcic
Fixing test
37f174e
zeljkobekcic
Merge branch 'fetch-weather'
8ee819a
@Supalien
Update Pipfile
a363d75
@Supalien
Added pillow to Pipfile under [packages] - again?
3fee94b
@Supalien
Merge branch 'master' into frontend
75259b3
@Supalien
Added GUI icons to setup.py
9997b27
@Supalien
wrong directory
e103044
JonasKsand others added 27 commits March 3, 2019 13:45
@JonasKs
Moved app to __main__, reverted to 'python -m project' in Pipfile. Li…
90f146d
…nting WILL fail because of unused imports, but I've left them in, so that the team members can see how the imports should be done. Also put all variables in init, renamed all variables to be pythonic, capital letter in classname and so on.
@JonasKs
Merging new structure into master. See commits.
fb74711
@Supalien
search_function is now called when the user presses Enter.
2f362b1
@JonasKs
Merged master into my branch
e73af49
@Supalien
Rewritted the code so it will be ready when@hotfixwill get the back…
0f9a7a1
…ground images.
@Supalien
Fixed a bug in line 71.
d7e8a9e
@JonasKs
Merged master into my branch
4b76b36
@Supalien
Forgot to pack main_canvas making the whole program blank.
e0b0261
@JonasKs
Merge hotfix into my branch
07e3f9d
@Supalien
load_owm_api_key doesnt get a path parameter anymore because OWM_API_…
b04ec00
…KEY is not going to change places.
@Supalien
added a quick way to setup the app through Pipenv.
d70a429
zeljkobekcic
Setting the api key path to a default one
be83697
@JonasKs
Merged master into feature branch
59b2ca6
@Supalien
unfinished work, commiting so it won't get overwritten.
71d8407
zeljkobekcic
Fixing an error for the input "random"
12a76dd
@JonasKs
Used backend to print out information about the weather.
74e8f93
@Supalien
fix merge conflicts
4d8e814
@JonasKs
Fixed a few things and added sample functions for functionality
ee9b62c
@JonasKs
Merged feature branch into Master.
d260ea2
zeljkobekcic
fixing linting error in weather.py
e51669f
@Supalien
Merge branch 'master' ofhttps://github.com/jonasks/code-jam-4
569b4e6
@Supalien
program now changes background according to the weather (hopefully) i…
7d04e5e
…n an ugly way.
@Supalien
forgot something
f79268b
@Supalien
Fixed variable problem and added clear to setup.py
640e814
@Supalien
program now changes background images properly
0cf19ad
@JonasKs
Fixed linting, updated README with instructions and description. Mino…
3e4cdd5
…r fixes to the project file, such as docstrings.
@JonasKs
Fixed linting, updated README with instructions and description. Mino…
519974f
…r fixes to the project file, such as docstrings.(second push, forgot to gitt add #tired
@jb3

jb3 commented Mar 7, 2019

Copy link
Copy Markdown
Member

Interesting project! Your setup instructions in README.md are fantastic.

You've used a setup.py file which breaks with the convention of using a Pipfile for package management & scripts. You also committed your .idea directory which should ideally be added to your .gitignore.

You raise an AttributeError when the key is not set which isn't really an appropriate error, also you should consider storing your API key somewhere which is not committed to git.

Code quality is good though and consistent throughout the project.

@JonasKs

JonasKs commented Mar 7, 2019

Copy link
Copy Markdown
Author

You're right, I totally missed the .idea, probably was done by PyCharm on my windows environment. My bad!

We added the key so you were able to use the app without registering through another site 😊

Thanks for the feedback!

@JonasKsJonasKs closed this Jun 12, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JonasKs@jb3@Supalien@V1CT0RIX