Uh oh!
There was an error while loading. Please reload this page.
Conversation
coveralls
commented
Dec 19, 2018
Pull Request Test Coverage Report for Build 1407
💛 - Coveralls |
wwwjfy
commented
Dec 19, 2018
While I don't have a problem with the implementation (a bit hacky though), this situation makes me feel like it's a dilemma. I want to say no, but I can't give a solution to that, so I'll hope someday we can have a better, more async friendly solution. (Sorry, I haven't checked what SQLTap does and how much effort to rebuild an async version.) |
684f7b1 to
3969c27Comparewwwjfy
commented
Mar 23, 2019
fantix
commented
Mar 25, 2019
Oh yeah, I felt the same way as you did. A complete implementation would be nice, but I don't know how yet. |
d3bba04 to
79e7d4cCompare
Fixes#412
before_cursor_execute()andafter_cursor_execute()is untouched - maybe we can create new events forasync_execute()if needed by someone.rowcountplease? It's not a public API so it should be fine in most cases.