Uh oh!
There was an error while loading. Please reload this page.
counter_incs by incrementRows - #89
Conversation
landscape-bot
commented
Apr 29, 2015
|
There was a problem hiding this comment.
Perhaps counters_inc is a better name? And can you move it below counter_dec for clarity?
There was a problem hiding this comment.
Yes, I agree and I will move it below counter_dec.
wbolster
commented
May 3, 2015
Hi, thanks for working on this. I've added a few questions/comments. Any chance you can add some tests? |
ummae
commented
May 3, 2015
Sure, and I found some conventional problem on PEP8 styles(e.g. line break 79bytes, etc..). |
- Renaming method counter_incs to counters_inc - Add nose tests for counters_inc
- Renaming method counter_incs to counters_inc - Add nose tests for counters_inc
landscape-bot
commented
May 3, 2015
|
landscape-bot
commented
May 3, 2015
|
ummae
commented
May 7, 2015
@wbolster Hi would you review this commit? |
wbolster
commented
May 7, 2015
Thanks for working on this. See comments about using a |
landscape-bot
commented
May 7, 2015
|
ummae
commented
May 7, 2015
I applied eventually ;) |
landscape-bot
commented
May 7, 2015
|
ummae
commented
Jul 12, 2015
@wbolster Hi, I wonder do you mind to merge ;) and one question would you have plan happybase version2 for thrift2 protocol |
wbolster
commented
Jul 19, 2015
philip-sterne
commented
Oct 12, 2015
RajatGoyal
commented
Sep 23, 2016
Any progress on this, It would be great If i can increase counters in bulk. |
related: #35
I am not sure that is proper way, but at least it works.