Skip to content

Add natural_list - #110

Merged
hugovk merged 14 commits into
python-humanize:mainfrom
akshaybabloo:main
Oct 5, 2024
Merged

Add natural_list#110
hugovk merged 14 commits into
python-humanize:mainfrom
akshaybabloo:main

Conversation

@akshaybabloo

@akshaybablooakshaybabloo commented Apr 21, 2023

Copy link
Copy Markdown
Contributor
  • This PR adds natural_list to convert a list of items into a comma separated sentence with and at the last.
  • I have also ignored .idea/* folder

closes#103

@codecov

codecovBot commented Apr 21, 2023

Copy link
Copy Markdown

Codecov Report

Merging #110 (14d76fb) into main (7e20f6e) will decrease coverage by 0.78%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## main #110 +/- ##
==========================================
- Coverage 99.06% 98.28% -0.78% 
==========================================
Files 9 11 +2 Lines 745 759 +14 ==========================================
+ Hits 738 746 +8 - Misses 7 13 +6 
FlagCoverage Δ
macos-latest96.70% <100.00%> (-1.15%)⬇️
ubuntu-latest96.70% <100.00%> (-1.15%)⬇️
windows-latest95.25% <100.00%> (-0.72%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
src/humanize/__init__.py81.81% <100.00%> (-18.19%)⬇️
src/humanize/lists.py100.00% <100.00%> (ø)
tests/test_lists.py100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@akshaybabloo
akshaybablooforce-pushed the main branch 3 times, most recently from 05289bd to 133a037CompareApril 22, 2023 06:55
@akshaybablooakshaybabloo changed the title Add naturalistAdd naturallistApr 22, 2023
@hugovkhugovk added the changelog: Added For new features label Apr 22, 2023
@akshaybabloo

Copy link
Copy Markdown
ContributorAuthor

Could you please run the CI again? Thanks.

@hugovkhugovk changed the title Add naturallistAdd natural_listOct 5, 2024
@hugovk

Copy link
Copy Markdown
Member

Thanks for the PR! I've made some updates, and because this is a new API, added an underscore to the function.

(I'm considering adding underscores to the others too, and having the non-underscore ones be aliases. If so, no need to remove or deprecate the old ones, at least not for a long time.)

@hugovk
hugovk merged commit d7f5dc5 into python-humanize:mainOct 5, 2024
@hugovkhugovk mentioned this pull request Oct 5, 2024
@hugovkhugovk changed the title Add natural_listAdd natural_listOct 5, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: AddedFor new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Natural list

3 participants

@akshaybabloo@hugovk@FPA-AkshayGollahalli