Skip to content

Add black and updated docs - #216

Merged
alexppg merged 5 commits into
python-microservices:masterfrom
felipem775:master
Oct 15, 2020
Merged

Add black and updated docs#216
alexppg merged 5 commits into
python-microservices:masterfrom
felipem775:master

Conversation

@felipem775

@felipem775felipem775 commented Oct 11, 2020

Copy link
Copy Markdown

No description provided.

@coveralls

coveralls commented Oct 11, 2020•
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 86.538% when pulling c481c0a on felipem775:master into 8ea55dd on python-microservices:master.

@felipem775
felipem775 marked this pull request as draft October 11, 2020 22:17
@felipem775felipem775 changed the title fix: Replace parameter for pip. -e should be -rdoc: Replace parameter for pip. -e should be -rOct 11, 2020
avara1986
avara1986 requested changes Oct 11, 2020
View reviewed changes
Comment threadrequirements-dev.txt
Comment threadpyproject.toml
Comment thread.pre-commit-config.yaml Outdated
@felipem775felipem775 changed the title doc: Replace parameter for pip. -e should be -rAdd black and updated docsOct 11, 2020
@avara1986avara1986 linked an issue Oct 12, 2020 that may be closed by this pull request
Support Black #215
Closed
@avara1986
avara1986 marked this pull request as ready for review October 15, 2020 18:04
@alexppg

alexppg commented Oct 15, 2020

Copy link
Copy Markdown
Member

What do you thing about adding pytest-black to the CI to make sure everybody uses it? https://pypi.org/project/pytest-black/@avara1986@felipem775

@avara1986

avara1986 commented Oct 15, 2020

Copy link
Copy Markdown
Member

Good idea @alexppg! but we could add this package in these steps:

  • Add black with pre-commit
  • Update all repository with black's changes
  • Add pytest-black to prevent new "errors" of format

What do you say? :) do we create a issue to add this validation? 💪

@alexppg

alexppg commented Oct 15, 2020

Copy link
Copy Markdown
Member

Nice, done then. #218 and #219

@alexppg
alexppg merged commit eee9732 into python-microservices:masterOct 15, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avara1986avara1986avara1986 approved these changes
@alexppgalexppgalexppg approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Black

4 participants

@felipem775@coveralls@alexppg@avara1986