Skip to content

typing - 'gtid.py', 'exceptions.py', 'binlogstream.py', 'packet.py' - #85

Open
heehehe wants to merge 7 commits into
mainfrom
feature/typing-gtid-exception-binlogstream-packet
Open

typing - 'gtid.py', 'exceptions.py', 'binlogstream.py', 'packet.py'#85
heehehe wants to merge 7 commits into
mainfrom
feature/typing-gtid-exception-binlogstream-packet

Conversation

@heehehe

@heeheheheehehe commented Sep 5, 2023

Copy link
Copy Markdown
Member

#81 커밋 내역 시점이 섞여 들어가서 새로운 브랜치 만들어서 다시 PR 올립니다..!!

heeheheand others added 3 commits September 5, 2023 10:29
Co-authored-by: mjs1995 <munmun2004@naver.com>
Co-authored-by: mikaniz <k515jina@gmail.com>
Co-authored-by: starcat37 <starcat37@korea.ac.kr>
Co-authored-by: starcat37 <starcat37@korea.ac.kr>
@heeheheheehehe changed the title typing - 'gtid.py', 'exceptions.py', 'binlogstream.py'typing - 'gtid.py', 'exceptions.py', 'binlogstream.py', 'packet.py'Sep 5, 2023
@heeheheheehehe added the 3조 3조 만세 label Sep 5, 2023
@heehehe
heeheheforce-pushed the feature/typing-gtid-exception-binlogstream-packet branch from cc6ac07 to 0eefeb4CompareSeptember 5, 2023 02:51
@@ -66,17 +70,17 @@ def __init__(self, value):
except KeyError:
pass
else:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

위에서 tuple인 경우를 거르니까 str만 오지않을까 싶습니다!

Co-authored-by: sean-k1 <sean.k1@kakaoent.com>
@heehehe
heeheheforce-pushed the feature/typing-gtid-exception-binlogstream-packet branch from 0eefeb4 to b265259CompareSeptember 6, 2023 09:14

@dongwook-chandongwook-chan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3조를 끝으로 typing 마무리 되었네요!! 고생 많으셨습니다!!

Comment threadpymysqlreplication/binlogstream.py Outdated
Comment threadpymysqlreplication/binlogstream.py Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3조3조 만세

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@heehehe@sean-k1@dongwook-chan@starcat37@mjs1995@mikaniz