Skip to content

UA locale - #793

Merged
Secrus merged 4 commits into
python-pendulum:masterfrom
OleksiiGerasymenko:master
Dec 17, 2024
Merged

UA locale#793
Secrus merged 4 commits into
python-pendulum:masterfrom
OleksiiGerasymenko:master

Conversation

@OleksiiGerasymenko

@OleksiiGerasymenkoOleksiiGerasymenko commented Jan 8, 2024

Copy link
Copy Markdown
Contributor

Ukraine locale

@codspeed-hq

codspeed-hqBot commented Jan 9, 2024

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #793 will not alter performance

Comparing OleksiiGerasymenko:master (5ca1f02) with master (3e3fec6)

Summary

✅ 1 untouched benchmarks

@ALERTua

Copy link
Copy Markdown

I would love to see my language in my favorite Python module!

@Secrus

Copy link
Copy Markdown
Collaborator

I would love to see my language in my favorite Python module!

I would love to merge it, but as you can see, CI currently fails. Once it's fixed, it can be merged.

@OleksiiGerasymenko

Copy link
Copy Markdown
ContributorAuthor

@Secrus@ALERTua can you help to fix this pls

@ALERTua

Copy link
Copy Markdown

I am sorry, the linting error seems not very informative to me. There is a trailing whitespace, but where? Maybe @Secrus could help.

@drtwisted

Copy link
Copy Markdown

Ping? Any updates on this?

@ALERTua

Copy link
Copy Markdown

kind reminder

@Secrus

Copy link
Copy Markdown
Collaborator

Once it is rebased and pipelines are green I don't see any issue with merging it.

@ALERTua

Copy link
Copy Markdown

@OleksiiGerasymenko ping :)

@SecrusSecrus closed this Dec 17, 2024
@SecrusSecrus reopened this Dec 17, 2024
@Secrus
Secrus merged commit a69761e into python-pendulum:masterDec 17, 2024
@OleksiiGerasymenko

OleksiiGerasymenko commented Dec 19, 2024

Copy link
Copy Markdown
ContributorAuthor

Bardzo dziękuję!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@OleksiiGerasymenko@ALERTua@Secrus@drtwisted