Skip to content

Fix parsing invalid intervals - #843

Merged
Secrus merged 2 commits into
python-pendulum:masterfrom
wiget:single-slash
Dec 4, 2024
Merged

Fix parsing invalid intervals#843
Secrus merged 2 commits into
python-pendulum:masterfrom
wiget:single-slash

Conversation

@wiget

@wigetwiget commented Sep 11, 2024

Copy link
Copy Markdown
Contributor

Parsing a string with a slash at the start or the end raised IndexError instead of ParseError.

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@wiget

wiget commented Sep 17, 2024

Copy link
Copy Markdown
ContributorAuthor

@sdispater would you mind reviewing this PR?

@codspeed-hq

codspeed-hqBot commented Sep 22, 2024•
edited
Loading

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #843 will not alter performance

Comparing wiget:single-slash (ae719c6) with master (b84b976)

Summary

✅ 1 untouched benchmarks

Secrus
Secrus reviewed Sep 22, 2024
View reviewed changes
Comment threadsrc/pendulum/parsing/__init__.py Outdated
@johnslavik

johnslavik commented Sep 22, 2024

Copy link
Copy Markdown

If I could suggest something, it would be just using [:1] instead of [0:1], as the former simply works and is less unnecessarily explicit.

Similarly to how you would probably prefer reading range(10) than range(0, 10).

@wiget

wiget commented Sep 23, 2024

Copy link
Copy Markdown
ContributorAuthor

@bswck You are right. Suggestion applied.

@wigetwiget mentioned this pull request Oct 10, 2024
Closed
@wiget

wiget commented Oct 24, 2024

Copy link
Copy Markdown
ContributorAuthor

@Secrus would you mind reviewing this PR?

@temporaertemporaer mentioned this pull request Oct 28, 2024
Closed
@wiget

wiget commented Nov 21, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review.

What is required to get this PR merged?

@Secrus

Secrus commented Nov 21, 2024

Copy link
Copy Markdown
Collaborator

@wiget please rebase your branch with master so the pipelines run. Right now it looks like GH has some issues here.

@wiget
Fix parsing invalid intervals
d9a6917
Parsing string with slash at the start or the end raised IndexError
instead of ParseError.
@wiget
Apply suggestion from review
ae719c6
@wiget

wiget commented Dec 3, 2024

Copy link
Copy Markdown
ContributorAuthor

All checks passed. Would you mind merging this PR, @Secrus ?

@Secrus
Secrus merged commit 6205754 into python-pendulum:masterDec 4, 2024
@bennetrr

bennetrr commented Dec 5, 2024

Copy link
Copy Markdown

Is there a release planned for this?

@wiget
wiget deleted the single-slash branch December 5, 2024 21:58
@saengowpsaengowp mentioned this pull request Feb 24, 2025
Open
@SecrusSecrus mentioned this pull request Apr 18, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SecrusSecrusSecrus approved these changes
+1 more reviewer
@johnslavikjohnslavikjohnslavik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wiget@johnslavik@Secrus@bennetrr