Uh oh!
There was an error while loading. Please reload this page.
Add complex text support - #1682
Conversation
b82ec14 to
5bd6ce4Comparewiredfool
commented
Jan 25, 2016
Thanks for the contribution. This is something that have been requested several times. From a quick look at this I've got several concerns:
|
wiredfool
commented
Jan 25, 2016
Also, please don't rebase PRs when we're reviewing them. |
khaledhosny
commented
Jan 25, 2016
Raqm depends on HarfBuzz, which is not packaged for Precise. For the other point, would providing fallback code for when Raqm is missing (that does essentially what the old code is doing) an acceptable compromise? |
wiredfool
commented
Jan 25, 2016
I think I'd want fallback code to be comfortable merging this. I'd also want to update the scripts in the |
877e0f9 to
07d96e0CompareShamsaHamed
commented
Jan 26, 2016
I am working on fallback code in case that Raqm is missing, so it will use the old code. |
ShamsaHamed
commented
Feb 3, 2016
This provide the documentation, testing and fallback code. |
hugovk
commented
Feb 3, 2016
Travis CI didn't build. I checked .travis.yml on https://lint.travis-ci.org/ and it said:
|
ShamsaHamed
commented
Feb 3, 2016
The failure is due to merge conflict, so I will rebase this after you finish reviewing the code. |
wiredfool
commented
Feb 3, 2016
Go ahead and fix the merge conflicts so we can get good test runs on this. |
6468cf7 to
9dd39e9CompareThis pull request adds support for languages that require complex text layout. We are using the Raqm library, that wraps FriBidi (for bidirectional text support) and HarfBuzz (for text shaping), and does proper BiDi and script itemization: https://github.com/HOST-Oman/libraqm This should fixpython-pillow#1089.
719890a to
0c9f04fCompare4e584ca to
9d806eeComparec419212 to
b15f362CompareShamsaHamed
commented
Feb 22, 2016
I have a problem in testing file I have added. I run it locally and it is ok, but I can't find why it fails during travis-ci buliding. Even I can't reproduce the issue locally. |
andreymal
commented
Dec 9, 2016
Any progress with this? @ShamsaHamed can you upgrade this to Pillow 3.4.2? Then I will try to find and fix problems with the tests, if possible (this feature is needed for me :) |
wiredfool
commented
Jul 1, 2017
Closed, merged with #2576 Thanks to everyone who worked on this, I think it's a valuable addition to the library. |
ShamsaHamed
commented
Jul 1, 2017
Thanks to you for your efforts and sorry for my absence to complete the work. I have a problem with my device. |
This pull request adds support for languages that require complex text layout.
We are using the Raqm library, that wraps FriBidi (for bidirectional
text support) and HarfBuzz (for text shaping), and does proper BiDi and script
itemization:
https://github.com/HOST-Oman/libraqm
This should fix#1089.