Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Remove unused LogRecorder class - #182

Merged
pquentin merged 2 commits into
python-trio:masterfrom
RatanShreshtha:remove_LogRecorder
Dec 1, 2019
Merged

Remove unused LogRecorder class#182
pquentin merged 2 commits into
python-trio:masterfrom
RatanShreshtha:remove_LogRecorder

Conversation

@RatanShreshtha

Copy link
Copy Markdown
Member

Fixes#130

@codecov

codecovBot commented Dec 1, 2019

Copy link
Copy Markdown

Codecov Report

Merging #182 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #182 +/- ##
==========================================
- Coverage 99.66% 99.49% -0.17% 
==========================================
Files 28 28 Lines 2721 1998 -723 ==========================================
- Hits 2712 1988 -724 - Misses 9 10 +1
Impacted FilesCoverage Δ
src/urllib3/util/wait.py91.83% <0%> (-8.17%)⬇️
src/urllib3/_async/connection.py98.44% <0%> (-0.14%)⬇️
src/urllib3/_async/poolmanager.py100% <0%> (ø)⬆️
src/urllib3/_async/connectionpool.py100% <0%> (ø)⬆️
src/urllib3/_async/request.py100% <0%> (ø)⬆️
src/urllib3/_async/response.py100% <0%> (+0.22%)⬆️

@pquentinpquentin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RatanShreshtha. Please remove the _ListHandler class just above and the logging import too

@pquentinpquentin closed this Dec 1, 2019
@pquentinpquentin reopened this Dec 1, 2019
@pquentin
pquentin merged commit f42cbc9 into python-trio:masterDec 1, 2019
@pquentin

Copy link
Copy Markdown
Member

Thanks!

@RatanShreshtha
RatanShreshtha deleted the remove_LogRecorder branch December 1, 2019 22:46
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused LogRecorder class in tests

2 participants

@RatanShreshtha@pquentin