Adding typing hints by ThosRTanner · Pull Request #773 · python-zk/kazoo

ThosRTanner · 2026-04-19T21:23:49Z

Fixes #

Why is this needed?

Proposed Changes

change 1
change 2
...

Does this PR introduce any breaking change?

codecov · 2026-04-23T06:02:51Z

Codecov Report

❌ Patch coverage is 99.01424% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.58%. Comparing base (86e69f2) to head (ebb5665).
⚠️ Report is 10 commits behind head on master.

Files with missing lines	Patch %	Lines
kazoo/handlers/eventlet.py	92.10%	3 Missing ⚠️
kazoo/protocol/connection.py	95.77%	3 Missing ⚠️
kazoo/handlers/utils.py	97.87%	1 Missing ⚠️
kazoo/protocol/serialization.py	99.26%	1 Missing ⚠️
kazoo/recipe/lock.py	97.91%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #773 +/- ##
==========================================
- Coverage 96.67% 95.58% -1.10% 
==========================================
Files 27 27 Lines 3553 3895 +342 ==========================================
+ Hits 3435 3723 +288 - Misses 118 172 +54

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

StephenSorriaux · 2026-04-29T02:13:41Z

Really appreciate the tons of work you put into this PR. Can't wait to see it ready!

ThosRTanner · 2026-04-29T19:44:08Z

Really appreciate the tons of work you put into this PR. Can't wait to see it ready!
I shall probably put in a brand new PR - this one is a bit of a mess considering my problems with hound...

This adds nearly full type hinting, and enables all but two of the mypy checks that were enabled in the mypy section in pyproject.toml. I hope to address the remaining checks, but it was proving tricky to address some of the 'typing.Any' uses. Also if you enable deprecation checks with --enable-error-code=deprecated You'll get warnings if you use deprecated options (at least as far as I was able to spot them!) This addresses python-zk#647 but there's not entirely strict checking as yet. Although I've tried very hard not to change any code for this, some `return None` statements have been added, which has caused the code coverage to drop as apparently those return paths were not covered by the testing. Also I've been less polite with the testing, and have changed the code in a number of places, including dropping test classes that did nothing, and adding asserts here and there to keep mypy happy as it sometimes doesn't spot a value could have been changed. I've added FIXMEs to address some of the more egregious type warning suppression that I did to avoid doing code changes, and intend to address those in another PR. A note: I've also had to suppress some errors in flake8 and use more general 'type: ignore' suppressions than I'd like because hound CI does something very very odd and tries to parse the text in the [] of the type: ignore[] comments as python, and generates some very peculiar messages.

ThosRTanner · 2026-05-16T20:05:01Z

closed in favour of 791 because this is now unreadable

ThosRTanner · 2026-05-20T20:20:08Z

Really appreciate the tons of work you put into this PR. Can't wait to see it ready!
@StephenSorriaux I've closed this PR and opened a new one mainly because of the stream of hound errors which makes this almost unreadable - see #791

houndci-bot reviewed Apr 19, 2026
View reviewed changes

ThosRTanner force-pushed the add-typing-hints branch from 67b03cf to 4253758Compare April 19, 2026 21:33

houndci-bot reviewed Apr 19, 2026
View reviewed changes

ThosRTanner force-pushed the add-typing-hints branch from 4253758 to 0739cf6Compare April 21, 2026 19:09

houndci-bot reviewed Apr 21, 2026
View reviewed changes

ThosRTanner force-pushed the add-typing-hints branch from 0739cf6 to 48e9478Compare April 21, 2026 21:15

houndci-bot reviewed Apr 21, 2026
View reviewed changes

ThosRTanner force-pushed the add-typing-hints branch from 48e9478 to b2e245dCompare April 22, 2026 07:19

houndci-bot reviewed Apr 22, 2026
View reviewed changes

Comment threadkazoo/client.py
Comment threadkazoo/client.py

ThosRTanner force-pushed the add-typing-hints branch 3 times, most recently from 339f1ec to 7edcb3bCompare April 22, 2026 17:08

houndci-bot reviewed Apr 22, 2026
View reviewed changes

Comment threadkazoo/recipe/partitioner.py Outdated
Comment threadkazoo/recipe/watchers.py
Comment threadkazoo/recipe/watchers.py Outdated

ThosRTanner force-pushed the add-typing-hints branch 2 times, most recently from 5da635b to d67849aCompare April 23, 2026 05:56

ThosRTanner force-pushed the add-typing-hints branch 4 times, most recently from a9318af to 5168260Compare April 23, 2026 13:41

houndci-bot reviewed Apr 23, 2026
View reviewed changes

Comment threadkazoo/handlers/utils.py Outdated

ThosRTanner force-pushed the add-typing-hints branch 5 times, most recently from 7063c61 to f62a077Compare April 28, 2026 20:03

houndci-bot reviewed Apr 28, 2026
View reviewed changes

Comment threadkazoo/client.py Outdated
Comment threadkazoo/client.py Outdated
Comment threadkazoo/interfaces.py Outdated

ThosRTanner force-pushed the add-typing-hints branch 3 times, most recently from 5035143 to ec7dc06Compare April 28, 2026 21:15

ThosRTanner force-pushed the add-typing-hints branch 2 times, most recently from b724031 to f027cf3Compare May 3, 2026 08:06

ThosRTanner closed this May 3, 2026

ThosRTanner reopened this May 3, 2026

ThosRTanner force-pushed the add-typing-hints branch 2 times, most recently from 09c3b2e to b40a0daCompare May 3, 2026 21:20

ThosRTanner closed this May 7, 2026

ThosRTanner reopened this May 7, 2026

ThosRTanner closed this May 8, 2026

ThosRTanner reopened this May 8, 2026

houndci-bot reviewed May 9, 2026
View reviewed changes

Comment threadkazoo/tests/test_cache.py Outdated

ThosRTanner force-pushed the add-typing-hints branch 6 times, most recently from 1d2790c to 91934ffCompare May 10, 2026 16:16

houndci-bot reviewed May 12, 2026
View reviewed changes

Comment threadkazoo/tests/test_election.py
Comment threadkazoo/tests/test_election.py Outdated
Comment threadkazoo/tests/test_sasl.py Outdated

houndci-bot reviewed May 15, 2026
View reviewed changes

Comment threadkazoo/tests/test_sasl.py Outdated

ThosRTanner force-pushed the add-typing-hints branch from 9d67e4b to b8854deCompare May 15, 2026 19:14

ThosRTanner force-pushed the add-typing-hints branch from d920398 to ebb5665Compare May 16, 2026 19:55

ThosRTanner closed this May 16, 2026

Uh oh!

Conversation

ThosRTanner commented Apr 19, 2026

Why is this needed?

Proposed Changes

Does this PR introduce any breaking change?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecovBot commented Apr 23, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StephenSorriaux commented Apr 29, 2026

Uh oh!

ThosRTanner commented Apr 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ThosRTanner commented May 16, 2026

Uh oh!

ThosRTanner commented May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

codecovBot commented Apr 23, 2026•
edited
Loading