Skip to content

Label a PR before posting the blurb help comment - #492

Merged
ezio-melotti merged 1 commit into
python:mainfrom
DanielNoord:news-order
Aug 5, 2022
Merged

Label a PR before posting the blurb help comment#492
ezio-melotti merged 1 commit into
python:mainfrom
DanielNoord:news-order

Conversation

@DanielNoord

Copy link
Copy Markdown
Contributor

Follow up to #485

python/cpython#94828 shows the previous PR works: changes to documentation are correctly labeled as skip news.
However, we're doing the check for the blurb_it help comment before we do the labeling.

This makes it so that we don't check whether we need to post that comment if we are going to label a PR as skip news.

/CC @ezio-melotti

@codecov

codecovBot commented Jul 14, 2022

Copy link
Copy Markdown

Codecov Report

Merging #492 (a496aea) into main (8e5ceb2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## main #492 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 18 18 Lines 1826 1829 +3 Branches 222 223 +1 =========================================
+ Hits 1826 1829 +3 
FlagCoverage Δ
Python_3.10100.00% <100.00%> (ø)
Python_3.11-dev100.00% <100.00%> (ø)
Python_3.8100.00% <100.00%> (ø)
Python_3.9100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
bedevere/filepaths.py100.00% <100.00%> (ø)
bedevere/prtype.py100.00% <100.00%> (ø)
tests/test_filepaths.py100.00% <100.00%> (ø)

Comment threadbedevere/filepaths.py
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DanielNoord@ezio-melotti