Skip to content

Add version subcommand - #29

Merged
hugovk merged 3 commits into
python:mainfrom
hugovk:add-version
Oct 12, 2024
Merged

Add version subcommand#29
hugovk merged 3 commits into
python:mainfrom
hugovk:add-version

Conversation

@hugovk

Copy link
Copy Markdown
Member

Make it easier to find the version by adding common options.

Before

blurb --versionError: Unknown subcommand: --versionRun 'blurb help' for help.blurb -vError: Unknown subcommand: -vRun 'blurb help' for help.blurb versionError: Unknown subcommand: versionRun 'blurb help' for help.blurb helpblurb version 1.2.2.dev8Management tool for CPython Misc/NEWS and Misc/NEWS.d entries.Usage: blurb [subcommand] [options...]Available subcommands: add Add a blurb (a Misc/NEWS.d/next entry) to the current CPython repo. export Removes blurb data files, for building release tarballs/installers. help Print help for subcommands. merge Merge all blurbs together into a single Misc/NEWS file. populate Creates and populates the Misc/NEWS.d directory tree. release Move all new blurbs to a single blurb file for the release. test Run unit tests. Only works inside source repo, not when installed.If blurb is run without any arguments, this is equivalent to 'blurb add'.

After

blurb --versionblurb version 1.2.2.dev8blurb -vblurb version 1.2.2.dev8blurb versionblurb version 1.2.2.dev8

@hugovkhugovk added the enhancement New feature or request label Oct 11, 2024

@ezio-melottiezio-melotti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codecov says the print is not covered by tests despite the line you added in the tox.ini. Should a simple test ran through pytest be added too?

Comment threadsrc/blurb/blurb.py Outdated
Comment threadsrc/blurb/blurb.py Outdated
Comment threadsrc/blurb/blurb.py Outdated
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@hugovk

Copy link
Copy Markdown
MemberAuthor

Codecov says the print is not covered by tests despite the line you added in the tox.ini. Should a simple test ran through pytest be added too?

Yes, we only have coverage through pytest. Sure, I can add a simple test case.

@ezio-melottiezio-melotti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk
hugovk merged commit a95b471 into python:mainOct 12, 2024
@hugovk
hugovk deleted the add-version branch October 12, 2024 15:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk@AA-Turner@ezio-melotti