Skip to content

Close #390: Ignore !buildbot comment if no builder matches - #400

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:pr_testing
Sep 21, 2023
Merged

Close #390: Ignore !buildbot comment if no builder matches#400
vstinner merged 1 commit into
python:mainfrom
vstinner:pr_testing

Conversation

@vstinner

Copy link
Copy Markdown
Member

Also, match the regex anywhere in the builder name, not only at the start.

Also, match the regex anywhere in the builder name, not only at the
start.
@vstinner
vstinner merged commit b3ee477 into python:mainSep 21, 2023
@vstinner
vstinner deleted the pr_testing branch September 21, 2023 23:04
@vstinner

Copy link
Copy Markdown
MemberAuthor

Ok, the change works as expected: python/cpython#109698 (comment)

I just made a typo, fixed by: 69e9ee1

@sentry

sentryBot commented Sep 29, 2023

Copy link
Copy Markdown

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️NameError: name 'builder' is not definedcustom.pr_testing in <listcomp>View Issue

Did you find this useful? React with a 👍 or 👎

@vstinner

Copy link
Copy Markdown
MemberAuthor

‼️ NameError: name 'builder' is not defined custom.pr_testing in View Issue

I fixed it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@vstinner