Uh oh!
There was an error while loading. Please reload this page.
Reduce refleak timeout from 3h20 to 45min - #543
Conversation
d17ab84 to
ef0b1b4Comparevstinner
commented
Oct 17, 2024
AMD64 Fedora Stable Refleaks 3.13 slowest test was 9 minutes, whereas a test was blocked for 3 hour 20 min. cc @zware |
ef0b1b4 to
1837fdfComparevstinner
commented
Oct 17, 2024
|
encukou
commented
Oct 23, 2024
There are slower builders on 3.10 which has monolithic Is there any extra background info for this change? Would it be better to revert it, or special-case the branches, like this for example? diff --git a/master/custom/factories.py b/master/custom/factories.py
index d4e703e..23dd122 100644
--- a/master/custom/factories.py+++ b/master/custom/factories.py@@ -72,6 +72,11 @@ class UnixBuild(BaseBuild):
# Adjust the timeout for this worker
self.test_timeout *= kwargs.get("timeout_factor", 1)
+ # Before 3.11, test_asyncio wasn't split up, so refleaks tests+ # need more time.+ if branch in ("3.9", "3.10") and has_option("-R", self.testFlags):+ self.test_timeout *= 2+
if self.build_out_of_tree:
self.addStep(
ShellCommand( |
vstinner
commented
Oct 23, 2024
When multiprocessing or concurrent.futures or another test hangs, we wasted 3h in waiting, whereas slowest test takes 18 min. Then buildbot overall timeout of 4h killed the re-run job. |
zware
commented
Oct 23, 2024
I'm in favor of either that kind of special case, or just dealing with it on the rare occasion that the 3.10 builders run. I definitely do not want to revert :) |
encukou
commented
Oct 24, 2024
I'd like to schedule some extra runs on those builders from time to time. Normal runs are meant for security fixes, and that's a bad time to discover latent issues. I filed the patch as #545 |
No description provided.