Uh oh!
There was an error while loading. Please reload this page.
Add a compatibility shim for migrating Android build tools to Platforms - #699
Conversation
| name="Set up compatibility symlink", | ||
| command=( | ||
| "[ -e Platforms/Android ]" | ||
| "|| ln -s ../Android Platforms/Android" |
There was a problem hiding this comment.
On Python 3.13, this command fails with:
ln: failed to create symbolic link 'Platforms/Android': No such file or directory
You should create the Platforms/ directory somehow. For example, add [ -e Platforms ] || mkdir Platforms; prefix to your command.
There was a problem hiding this comment.
🤦 I forgot that 3.14 has the Platforms directory; but 3.13 doesn't. Fixed.
| "[ -e Platforms/Android ]" | ||
| "|| ln -s ../Android Platforms/Android" | ||
| "&& ln -si ../Android/android.py Platforms/Android/__main__.py" |
There was a problem hiding this comment.
For readability, you should add spaces:
| "[ -e Platforms/Android ]" | |
| "|| ln -s ../Android Platforms/Android" | |
| "&& ln -si ../Android/android.py Platforms/Android/__main__.py" | |
| "[ -e Platforms/Android ]" | |
| "|| ln -s ../Android Platforms/Android" | |
| "&& ln -si ../Android/android.py Platforms/Android/__main__.py" |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Following the pattern used by the iOS build, adds a compatibility shim so that the buildbot will run
Platforms/Android, but that location will work on 3.13 and 3.14 repos that store the Android build code inAndroid/android.py.Also updates the iOS configuration to use the same general pattern for invoking the build script.
As part of this, the
CACHE_DIRconfiguration has been moved out of the buildbot definition, and into the environment where the buildbot is executed. This means the buildbot configuration is no longer sensitive to the specific user account that is hosting the buildbot instance.This configuration can be landed now, without the
Platformsmigration having been made - the Android folder exists in all 3.13+ repos as of right now. Once the Platforms migration occurs the symlink step will become a no-op.