Uh oh!
There was an error while loading. Please reload this page.
Add --bpo and --section flags to "blurb add". - #312
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: larryhastings <larry@hastings.org>
larryhastings
commented
Feb 28, 2019
Thanks for the suggestion, Mariatta! |
matrixise
left a comment
There was a problem hiding this comment.
I did a comment about the section parameter, but for me, it's nice.
just one question, the "section" represents the sections from bpo ?
| #.. section: Tools/Demos | ||
| #.. section: C API | ||
| {section} |
There was a problem hiding this comment.
why don't you keep the same principle with the .. bpo: {bpo}? at this line, you already have a constructed section.
You build the section at that line https://github.com/python/core-workflow/pull/312/files#diff-1bd652c5f766ddebec6cd6dc8f27b3b1R927
Do you make the construction before because you don't want to have a conditional template? is it right?
matrixise
commented
Mar 28, 2019
in my workflow, I could use that blurb add --bpo=(git rev-parse --abbrev-ref HEAD |sed-e's/bpo-//')so, I am happy with that solution and we can add some alias for the several sections...
|
hugovk
left a comment
There was a problem hiding this comment.
Works well! Needs a sync with master as blurb 1.0.8 has since been released.
| init_tmp_with_template() | ||
| if section: | ||
| if section not in sections: | ||
| error("blurb add --section argument " + repr(section) + " is not a valid section!") |
There was a problem hiding this comment.
How about printing the valid sections when this fails?
| error("blurb add --section argument "+repr(section) +" is not a valid section!") | |
| error("blurb add --section argument "+repr(section) +" is not a valid section! Use one of:\n"+"\n".join(sections)) |
For example:
$ python blurb.py add --bpo 123 --section aaaError: blurb add --section argument 'aaa' is not a valid section! Use one of:SecurityCore and BuiltinsLibraryDocumentationTestsBuildWindowsmacOSIDLETools/DemosC API
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
| 1.0.8 | ||
| ~~~~~ | ||
| - Added the ``--bpo`` and ``--section`` flags to |
There was a problem hiding this comment.
Does it make sense to use the bpo abbreviation, or would it be better as issue now?
hugovk
commented
Mar 28, 2024
This will need recreating for the new repo at https://github.com/python/blurb. I've opened python/blurb#6 for this. |
No description provided.