Skip to content

Add patch for ax_c_float_words_bigendian.m4 to autoconf-archive - #23

Merged
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:ax-c-float-words-bigendian
Oct 16, 2024
Merged

Add patch for ax_c_float_words_bigendian.m4 to autoconf-archive#23
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:ax-c-float-words-bigendian

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Oct 15, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@erlend-aaslanderlend-aasland linked an issue Oct 15, 2024 that may be closed by this pull request
Patch autoconf-archive with an updated variant of AX_C_FLOAT_WORDS_BIGENDIAN#22
Closed
@erlend-aasland

erlend-aasland commented Oct 15, 2024

Copy link
Copy Markdown
CollaboratorAuthor

The original autoconf-archive PR is here:

@corona10corona10 self-assigned this Oct 16, 2024
corona10
corona10 approved these changes Oct 16, 2024
View reviewed changes

@corona10corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

corona10
corona10 reviewed Oct 16, 2024
View reviewed changes

@corona10corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erlend-aasland
Nit comment:
If we have to vendor more custom patch, it might good to have own directory under autoconf, (e.g autoconf/diff)

@corona10

corona10 commented Oct 16, 2024

Copy link
Copy Markdown
Member

Feel free to merge this PR and publish new release when you want! through https://github.com/python/cpython-devcontainers/actions/workflows/release.yml

@erlend-aasland

erlend-aasland commented Oct 16, 2024

Copy link
Copy Markdown
CollaboratorAuthor

@erlend-aasland Nit comment: If we have to vendor more custom patch, it might good to have own directory under autoconf, (e.g autoconf/diff)

Yes, I thought about that, but I do not anticipate, nor hope, that there will be many patches :) If another patch is needed, let's introduce a more formal system for maintaining them.

@erlend-aasland
erlend-aasland merged commit d5e7029 into python:mainOct 16, 2024
@erlend-aasland
erlend-aasland deleted the ax-c-float-words-bigendian branch October 16, 2024 07:26
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Oct 16, 2024
@erlend-aasland
pythongh-89640: properly detect float word ordering on Linux
bd20441
Prerequisite: python/cpython-devcontainers#23
autoconf-archive patch by Dan Amelang.
@erlend-aaslanderlend-aasland mentioned this pull request Oct 16, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10corona10corona10 approved these changes

Assignees

@erlend-aaslanderlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Patch autoconf-archive with an updated variant of AX_C_FLOAT_WORDS_BIGENDIAN

2 participants

@erlend-aasland@corona10