Uh oh!
There was an error while loading. Please reload this page.
gh-22: Amend float detection patch to use private Autoconf variables - #30
Closed
erlend-aasland wants to merge 1 commit into
Closed
gh-22: Amend float detection patch to use private Autoconf variables#30erlend-aasland wants to merge 1 commit into
erlend-aasland wants to merge 1 commit into
Conversation
CollaboratorAuthor
@damelang: I think this is a safer choice; what do you think of upstreaming this amendment? |
corona10
commented
Oct 20, 2024
Member
Hmm by the way, please take a look at this issue too: #29 |
corona10
approved these changes
Oct 20, 2024
erlend-aasland
commented
Oct 20, 2024
CollaboratorAuthor
Thanks for the review, Donghee. I'll give Dan a chance to chime in before landing this. |
erlend-aasland
commented
Oct 21, 2024
CollaboratorAuthor
Actually, I don't think we should do this; most macros in autoconf-archive use |
erlend-aasland
marked this pull request as draft
October 21, 2024 08:17
erlend-aasland
commented
Oct 25, 2024
CollaboratorAuthor
See: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.