test_mmap are leaked

[Eclips4]

Tried on current main branch.

 ./python -m test -R 3:3 test_mmap
Running Debug|x64 interpreter...
0:00:00 Run tests sequentially
0:00:00 [1/1] test_mmap
beginning 6 repetitions
123456
......
test_mmap leaked [13, 13, 13] references, sum=39
test_mmap failed (reference leak)

== Tests result: FAILURE ==

1 test failed:
 test_mmap

Total duration: 1.3 sec
Tests result: FAILURE

OS: Windows 10 & WSL Ubuntu 20.04

Linked PRs

• gh-104698: Fix reference leak in mmapmodule.c #104700
• [3.11] gh-104698: Fix reference leak in mmapmodule.c (GH-104700) #104710

[Eclips4]

PR which introduce it: #103990

[AlexWaygood]

PR which introduce it: #103990

Cc. @Agent-Hellboy / @JelleZijlstra / @sunmy2019

[chgnrdv]

It seems like Py_buffer in mmap_gfind, mmap_write_method and mmap_ass_subscript should be released if CHECK_VALID fails.

[Eclips4]

It seems like Py_buffer in mmap_gfind, mmap_write_method and mmap_ass_subscript should be released if CHECK_VALID fails.

Yeah, you're right. I'll soon send a PR.

[sunmy2019]

It seems like Py_buffer in mmap_gfind, mmap_write_method and mmap_ass_subscript should be released if CHECK_VALID fails.

Yeah, I forgot about it.

I'll soon send a PR.

Thanks!

[JelleZijlstra]

Sorry for this, should have run the refleak buildbots before merging. Thanks @chgnrdv for the diagnosis and @Eclips4 for the PR.