Multiple tests failing when invoked directly via `./python Lib/test/...`

[tomasr8]

Besides test_pickle reported in #131031, there are a few more (test_regrtest, test_metaclass and test_pyclbr):

~ ./python Lib/test/test_regrtest.py
...
Ran 115 tests in 35.727s

FAILED (failures=1, skipped=2)

~ ./python Lib/test/test_metaclass.py
...
Ran 1 test in 0.018s

FAILED (failures=1)

~ ./python Lib/test/test_pyclbr.py
...
Ran 6 tests in 1.720s

FAILED (failures=1, errors=1)

Linked PRs

• gh-131290: ensure that test files can be executed as standalone scripts #131371

[MaximGit1]

Hello i would like to take for this

[sobolevn]

@MaximGit1 Thank you, please go ahead and ask any questions you have :)

[MaximGit1]

Hello, I am currently running "Lib/test/test_metaclass.py".

Running it directly (./python Lib/test/test_metaclass.py) works in the global namespace (main), so module becomes 'main'. This creates a conflict since the module should be called "test.test_metaclass".

To fix this, I decided to do this.

if __name__ == "__main__":
 __name__ = "test.test_metaclass" # predefined name
 unittest.main()

I think this is the best solution because I don't change the logic of the tests. How good do you think this solution is?

[MaximGit1]

@sobolevn I finished

[vstinner]

For regrtest, I would prefer this fix:

diff --git a/Lib/test/test_regrtest.py b/Lib/test/test_regrtest.py
index 510c8f69631..7e317d5ab94 100644
--- a/Lib/test/test_regrtest.py
+++ b/Lib/test/test_regrtest.py
@@ -2546,4 +2546,5 @@ def test_test_result_get_state(self):
 
 
 if __name__ == '__main__':
+ setup.setup_process()
 unittest.main()

[Eclips4]

Thank you @MaximGit1 for fixing this!