Cryptic error message about ENV CHANGED

[serhiy-storchaka]

See for example #132535.

When there are leaked resources that emit a resource warning in destructor, and the test was ran with the -Werror option, the warnings are converted to unhandled exceptions, and the error report will contain:

...

== Tests result: ENV CHANGED then ENV CHANGED ==

...

1 test altered the execution environment (env changed):
 test_timeout

...

Total test files: run=467/470 (filtered) env_changed=1 skipped=16 resource_denied=4 rerun=1
Result: ENV CHANGED then ENV CHANGED

...

These "ENV CHANGED then ENV CHANGED" look pretty cryptic for regular user. And "altered the execution environment (env changed)" is not particularly useful at all. Even if "env changed" is repeated in three places, it does not add clarity.

It would be nice to decipher it and provide more details. For every test explain what "environment" was altered in more human words -- leaked files, unhandled exceptions, etc.

Linked PRs

• gh-132581: Report why the execution environment was altered #155294
• gh-132581: Report why the execution environment was altered #155306

[hasrat17]

Hi, I’m interested in contributing to this issue. It currently appears to be open and unassigned, with no active pull request. May I take it up and start working on it?