wave.open does not accept PathLike objects

[mscuthbert]

BPO	31412
Nosy	@berkerpeksag, @serhiy-storchaka, @mscuthbert
PRs	bpo-31412: wave.open takes a path-like object #3484

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2017-09-10.18:41:03.935>
labels = ['3.7', 'type-feature', 'library']
title = 'wave.open does not accept PathLike objects'
updated_at = <Date 2017-11-01.09:01:18.609>
user = 'https://github.com/mscuthbert'

bugs.python.org fields:

activity = <Date 2017-11-01.09:01:18.609>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2017-09-10.18:41:03.935>
creator = 'mscuthbert'
dependencies = []
files = []
hgrepos = []
issue_num = 31412
keywords = ['patch']
message_count = 2.0
messages = ['301826', '305361']
nosy_count = 3.0
nosy_names = ['berker.peksag', 'serhiy.storchaka', 'mscuthbert']
pr_nums = ['3484']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue31412'
versions = ['Python 3.7']

Linked PRs

• gh-75593: Allow opening of path-like files with wave.open #140951

[mscuthbert]

The wave library (reading and writing .wav audio files) accepts filehandles, strings, and bytes, but does not accept PathLike objects. Patch will modify wave.py to allow open to use these objects.

[serhiy-storchaka]

wave is a one of three audio file modules (aifc, sunau, wave) that should have the same interface.

[hugovk]

Note the aifc and sunau modules are deprecated in 3.11 and set for removal in 3.13.

See PEP 594 – Removing dead batteries from the standard library and #91217.

The wave module is being kept.

[mscuthbert]

The code I contributed to 3.7 is still, I believe, the best path forward. Based on my experiences trying to contribute to cpython, I will not be continuing on this issue. It can be closed.

[arhadthedev]

Based on my experiences trying to contribute to cpython, I will not be continuing on this issue. It can be closed.

After the migration, the issue pile finally started to actively reduce in size towards something manageable:

So your issue being accidentally pulled out-of-order from the abyss of 6,878 gives a great chance to finally see it merged.

I suspect that hugovk just noted that in September, 2023 two affected modules will cease to exist. However, we need to live till that date first, so your fix is still relevant in full volume.

... after a month, give-or-take, to allow anybody concerned a chance to give a fresh feedback. The important thing now is not to allow it to sink back.

[arhadthedev]

Actually, your PR is really just got buried under the fresher ones, no ghosting or deliberate ignorance is involved.

I suspect, everybody has such an experience here when even simple PRs sink under the radar and require once-per-month update to bring it back into the unread notifications. Here're my PRs, for example:

[AA-Turner]

The linked PR (#3484) was closed, although it doesn't say by whom -- I think it could be reopened and updated to drop the changes to the deprecated modules.

A

[arhadthedev]

I think it could be reopened and updated to drop the changes to the deprecated modules.

Can we keep them to make backporting easier (the PR fixes divergence from PEP 519 so I believe it's a bugfix and should be backported)?