Add tests for PEP 468 and PEP 520

[serhiy-storchaka]

BPO	34345
Nosy	@ericsnowcurrently, @serhiy-storchaka

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2018-08-06.12:08:19.097>
labels = ['3.7', '3.8', 'type-feature', 'tests']
title = 'Add tests for PEP 468 and PEP 520'
updated_at = <Date 2018-08-06.12:08:19.097>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2018-08-06.12:08:19.097>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2018-08-06.12:08:19.097>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 34345
keywords = []
message_count = 1.0
messages = ['323199']
nosy_count = 2.0
nosy_names = ['eric.snow', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue34345'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

Linked PRs

• gh-78526: Add tests for PEP 468 and PEP 520 #155387

[serhiy-storchaka]

AFAIK there no purposed tests for PEP-468 and PEP-520. If making dict not preserving order, noting related to these PEPs is failed.

I think we need explicit tests for PEP-468 and PEP-520. At least in 3.6 the dict order is not guaranteed. And even in 3.7+ preserving the dict order doesn't guarantee implementing PEP-468 and PEP-520. The order can be broken in a meanwhile (for example by iterating a list of keys in the reversed order).

[kumaraditya303]

There are tests ensuring insertion order of dict in test_dict.py so closing.

[ericsnowcurrently]

IMHO, it would be good to have explicit tests for this.