python3.8 a1 - docs build requires sphinx 1.7 but uses a 1.8 feature

[asottile]

BPO	36007
Nosy	@asottile, @Mariatta, @miss-islington
PRs	bpo-36007: Bump minimum sphinx version to 1.8 #11887

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-02-15.23:41:42.703>
created_at = <Date 2019-02-15.22:48:04.636>
labels = ['build', '3.8', 'docs']
title = 'python3.8 a1 - docs build requires sphinx 1.7 but uses a 1.8 feature'
updated_at = <Date 2019-02-15.23:51:48.223>
user = 'https://github.com/asottile'

bugs.python.org fields:

activity = <Date 2019-02-15.23:51:48.223>
actor = 'Mariatta'
assignee = 'docs@python'
closed = True
closed_date = <Date 2019-02-15.23:41:42.703>
closer = 'Mariatta'
components = ['Build', 'Documentation']
creation = <Date 2019-02-15.22:48:04.636>
creator = 'Anthony Sottile'
dependencies = []
files = []
hgrepos = []
issue_num = 36007
keywords = ['patch']
message_count = 4.0
messages = ['335654', '335655', '335658', '335659']
nosy_count = 4.0
nosy_names = ['docs@python', 'Anthony Sottile', 'Mariatta', 'miss-islington']
pr_nums = ['11887']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue36007'
versions = ['Python 3.8']

[asottile]

doctest `:skipif:` was added in sphinx-doc/sphinx#5273

Used here: https://github.com/python/cpython/blame/36433221f06d649dbd7e13f5fec948be8ffb90af/Doc/library/turtle.rst#L252-L253

Sphinx minimum version configured here:

cpython/Doc/conf.py

Lines 44 to 45 in 3643322

	# Require Sphinx 1.7 for build.
	needs_sphinx = '1.7'

Should this be upped to 1.8 or should the :skipif: be removed? My guess is the former, I'd be happy to contribute a patch

I hit this while packaging 3.8.0a1 for deadsnakes

[Mariatta]

Let's up the sphinx version.
Thanks.

[miss-islington]

New changeset a16ab00 by Miss Islington (bot) (Anthony Sottile) in branch 'master':
bpo-36007: Bump minimum sphinx version to 1.8 (GH-11887)
a16ab00

[Mariatta]

Thanks!