Improve/fix FreeBSD Bluetooth socket support

[myfreeweb]

BPO	41130
Nosy	@koobs, @myfreeweb

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2020-06-26.19:00:41.062>
labels = ['3.8', 'type-feature', '3.7', '3.9', '3.10']
title = 'Improve/fix FreeBSD Bluetooth socket support'
updated_at = <Date 2020-06-26.19:00:41.062>
user = 'https://github.com/myfreeweb'

bugs.python.org fields:

activity = <Date 2020-06-26.19:00:41.062>
actor = 'myfreeweb'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['FreeBSD']
creation = <Date 2020-06-26.19:00:41.062>
creator = 'myfreeweb'
dependencies = []
files = []
hgrepos = []
issue_num = 41130
keywords = []
message_count = 1.0
messages = ['372439']
nosy_count = 2.0
nosy_names = ['koobs', 'myfreeweb']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue41130'
versions = ['Python 3.5', 'Python 3.6', 'Python 3.7', 'Python 3.8', 'Python 3.9', 'Python 3.10']

Linked PRs

• gh-85302: Add support for BTPROTO_SCO on FreeBSD #131981

[myfreeweb]

1. BTPROTO_HCI addresses only expect string identifiers on NetBSD and DragonFly:

   cpython/Modules/socketmodule.c

   Line 1931 in 2e0a920

   #if defined(__NetBSD__) || defined(__DragonFly__)

But of course this is true on FreeBSD too. (DragonFly inherited the BT stack from FreeBSD!)
For example this is how hccontrol creates an address:
https://github.com/freebsd/freebsd/blob/6bb9221a9b865ee432269099f341e4230a6cbcd4/usr.sbin/bluetooth/hccontrol/hccontrol.c#L115-L129

So currently it is not possible to bind an HCI socket (without using FFI to directly use the libc bind function) :(

2. BTPROTO_SCO is excluded on FreeBSD:

   cpython/Modules/socketmodule.c

   Line 1953 in 2e0a920

   #if !defined(__FreeBSD__)

But SCO has been supported since 2008: freebsd/freebsd-src@bb4c6de

[serhiy-storchaka]

(1) was fixed by #131668.