Skip to content

gh-99984: Fix Compiler Warnings#100036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 1 commit into from
Dec 5, 2022
Merged

gh-99984: Fix Compiler Warnings #100036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Modules/_xxsubinterpretersmodule.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2583,7 +2583,7 @@ channel_create(PyObject *self, PyObject *Py_UNUSED(ignored))
{
int64_t cid = _channel_create(&_globals.channels);
if (cid < 0) {
(void)handle_channel_error(cid, self, -1);
(void)handle_channel_error(-1, self, cid);
return NULL;
}
module_state *state = get_module_state(self);
Expand DownExpand Up@@ -2985,6 +2985,11 @@ module_exec(PyObject *mod)
return -1;
}

module_state *state = get_module_state(mod);
if (state == NULL) {
goto error;
}

/* Add exception types */
if (interp_exceptions_init(mod) != 0) {
goto error;
Expand All@@ -2994,7 +2999,6 @@ module_exec(PyObject *mod)
}

/* Add other types */
module_state *state = get_module_state(mod);

// ChannelID
state->ChannelIDType = add_new_type(
Expand Down