Skip to content

gh-81057: Move OS-Related Globals to _PyRuntimeState - #100082

Merged
ericsnowcurrently merged 6 commits into
python:mainfrom
ericsnowcurrently:consolidate-os-globals
Dec 8, 2022
Merged

gh-81057: Move OS-Related Globals to _PyRuntimeState#100082
ericsnowcurrently merged 6 commits into
python:mainfrom
ericsnowcurrently:consolidate-os-globals

Conversation

@ericsnowcurrently

@ericsnowcurrentlyericsnowcurrently commented Dec 7, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@ericsnowcurrently
ericsnowcurrently requested a review from a team as a code ownerDecember 7, 2022 17:15
@bedevere-botbedevere-bot mentioned this pull request Dec 7, 2022
Closed
@netlify

netlifyBot commented Dec 7, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for python-cpython-preview canceled.

NameLink
🔨 Latest commitb8befdc
🔍 Latest deploy loghttps://app.netlify.com/sites/python-cpython-preview/deploys/63925f7c5c9e170008558b26

@ericsnowcurrently
ericsnowcurrently removed the request for review from a teamDecember 7, 2022 17:17
@ericsnowcurrently
ericsnowcurrently merged commit cda9f02 into python:mainDec 8, 2022
@ericsnowcurrently
ericsnowcurrently deleted the consolidate-os-globals branch December 8, 2022 22:38
@vstinner

vstinner commented Dec 9, 2022

Copy link
Copy Markdown
Member

This change introduced a reference leak. Example with test_posixpath:

$ ./python -m test test_posixpath -R 3:3 -m test_ismount_directory_not_readable
(...)
test_posixpath leaked [9, 9, 9] references, sum=27
(...)

@vstinner

vstinner commented Dec 9, 2022

Copy link
Copy Markdown
Member

On PPC64LE Fedora Stable Refleaks 3.x, test_os and test_posixpath started to leak memory: https://buildbot.python.org/all/#builders/280/builds/548

@ericsnowcurrently

ericsnowcurrently commented Dec 9, 2022

Copy link
Copy Markdown
MemberAuthor

I'll get that fixed.

@ericsnowcurrentlyericsnowcurrently mentioned this pull request Dec 9, 2022
Merged
ericsnowcurrently added a commit that referenced this pull request Dec 9, 2022
@ericsnowcurrently
gh-81057: Fix a Reference Leak in the posix Module (gh-100140)
7a0f3c1
The leak was introduced in gh-100082.
#81057
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericsnowcurrently@vstinner@bedevere-bot