Uh oh!
There was an error while loading. Please reload this page.
gh-100165: Add BINARY_OP_AND_INT for integer & operation. - #100166
gh-100165: Add BINARY_OP_AND_INT for integer & operation.#100166corona10 wants to merge 4 commits into
Conversation
✅ Deploy Preview for python-cpython-preview canceled.
|
Stats
|
Uh oh!
There was an error while loading. Please reload this page.
…e-100165.GE1Iui.rst Co-authored-by: Ken Jin <kenjin@python.org>
Fidget-Spinner
commented
Dec 12, 2022
Let's wait for Mark before merging this. |
brandtbucher
commented
Dec 13, 2022
Does this improve the pyperformance results at all? If not, I'd suggest that we take a different approach (discussed with @markshannon this morning): Rather than try to add more and more non-performance-improving Once we get that working, the mechanism could be extended to cache the results of recent operator lookups (like the method cache) or even allow extensions like NumPy to register custom specializations. I'd be happy to run the pyperformance numbers for you if you want. I also have a small hunch that the pyperformance suite over-represents how often integer |
brandtbucher
commented
Dec 13, 2022
Also, see our previous rejection of this idea: #94109. |
corona10
commented
Dec 13, 2022
Ah, I agree that what we have to go.
Same result with Mark's last running: #94109 (comment) Well, I agree that this PR is not worth to merge. |
According to stats, BINARY_AND_INT will cover 50.7% of failures.