Skip to content

[3.11] GH-98363: Update batched() recipe in docs to match 3.12 - #100323

Merged
rhettinger merged 2 commits into
python:3.11from
rhettinger:batched_recipe_tuple
Dec 18, 2022
Merged

[3.11] GH-98363: Update batched() recipe in docs to match 3.12#100323
rhettinger merged 2 commits into
python:3.11from
rhettinger:batched_recipe_tuple

Conversation

@rhettinger

@rhettingerrhettinger commented Dec 17, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@rhettingerrhettinger added docs Documentation in the Doc dir skip news labels Dec 17, 2022
@bedevere-botbedevere-bot mentioned this pull request Dec 17, 2022
Closed
hauntsaninja
hauntsaninja reviewed Dec 17, 2022
View reviewed changes
Comment threadDoc/library/itertools.rst Outdated
CAM-Gerlach
CAM-Gerlach approved these changes Dec 18, 2022
View reviewed changes

@CAM-GerlachCAM-Gerlach left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a docs perspective, FWIW. Should this be backported to 3.10 as well?

@CAM-GerlachCAM-Gerlach mentioned this pull request Dec 18, 2022
Closed
@CAM-Gerlach

CAM-Gerlach commented Dec 18, 2022

Copy link
Copy Markdown
Member

Also, I noticed that though this PR was made from your fork per the usual flow. there is an apparent duplicate https://github.com/python/cpython/tree/batched_recipe_tuple branch on the upstream cpython repo. Does that need to be there, or can it be removed? It's the final blocker to implementing the final step of python/core-workflow#460 on cpython. Thanks!

@rhettinger
rhettinger merged commit 0918667 into python:3.11Dec 18, 2022
@rhettinger
rhettinger deleted the batched_recipe_tuple branch December 18, 2022 01:10
@rhettinger

rhettinger commented Dec 18, 2022

Copy link
Copy Markdown
ContributorAuthor

@CAM-Gerlach Yes, go ahead and remove the other branch.

@CAM-Gerlach

CAM-Gerlach commented Dec 18, 2022

Copy link
Copy Markdown
Member

Thanks, removed! 👍

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninjahauntsaninjahauntsaninja left review comments
@CAM-GerlachCAM-GerlachCAM-Gerlach approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rhettinger@CAM-Gerlach@hauntsaninja@bedevere-bot